Fix #24931 compare with known size of 'usedResourceHandles' instead of theoretical maximum 'maxConnectionPoolSize' #24932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' instead of theoretical maximum 'maxConnectionPoolSize'
This comment was marked as outdated.
This comment was marked as outdated.
dmatej
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
I tried to figure out the target of the test, but it seems it never was the using maximal capacity. Unfortunately sometimes those 100 tasks are too fast OR scheduler decides to not to start those threads if it noticed they often end waiting on lock. Interesting ...
dmatej
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24931 compare with known size of 'usedResourceHandles' instead of theoretical maximum 'maxConnectionPoolSize'
Changing logic to test against 'usedResourceHandles', which is tracked for each thread. No longer depend on maxConnectionPoolSize which might be used or not, depending on the machine the test runs on.