SpotBugs analysis: Holder.toString() may return null

[ghost]

Would returning "null", rather than null, be more idiomatic?

grizzly/modules/grizzly/src/main/java/org/glassfish/grizzly/utils/Holder.java

Line 70 in a2ce777

return obj != null ? "{" + obj + "}" : null;

toString method may return null
This toString method seems to return null in some circumstances. A liberal reading of the spec could be interpreted as allowing this, but it is probably a bad idea and could cause other code to break. Return the empty string or some other appropriate string rather than null.

Since at least 2.3.25.

Consider:

return obj == null ? "null" : "{" + obj + "}";

[mnriem]

@DaveJarvis Would you consider "{}" instead as the Holder object itself does exist, but rather it has nothing to hold onto?

[mnriem]

@DaveJarvis Can you create a PR for this?

[ghost]

@DaveJarvis Can you create a PR for this?

No, I'm moving off of GitHub soon.