src: drop NullaryFunction in favor or java.util.Supplier #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NullaryFunction has an equivalent in standard java API. So, lets use it.
|
@kofemann Is this change backwards compatible? |
|
@mnriem maybe we can just build it, and test it? E.g. by adding it to GlassFish and running all tests that we have? |
|
@mnriem I am pretty sure this is not a drop-in replacement. However, I have no idea which external applications use grizzly internals. So, I agree with @arjantijms, we just have to build packages, document the change and let depending applications to test. |
arjantijms
approved these changes
Sep 15, 2023
pzygielo
reviewed
Oct 28, 2023
| * | ||
| * @return Attribute<T> | ||
| */ | ||
| <T> Attribute<T> createAttribute(String name, org.glassfish.grizzly.utils.NullaryFunction<T> initializer); |
There was a problem hiding this comment.
With this removed, after switching client code to Supplier, the method left below is used, which is still marked as deprecated. This causes:
[WARNING] .../mq/main/mq-broker/broker-core/src/main/java/com/sun/messaging/jmq/jmsserver/service/imq/grizzly/GrizzlyMQPacketFilter.java:[42,13] <T>createAttribute(java.lang.String,org.glassfish.grizzly.attributes.NullaryFunction<T>) in org.glassfish.grizzly.attributes.AttributeBuilder has been deprecated
[INFO] 1 warning
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] .../mq/main/mq-broker/broker-core/src/main/java/com/sun/messaging/jmq/jmsserver/service/imq/grizzly/GrizzlyMQPacketFilter.java: warnings found and -Werror specified
[INFO] 1 error
There was a problem hiding this comment.
Looks like the depreciation left in place unintendedly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NullaryFunction has an equivalent in standard java API. So, lets use it.