-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up ee4j #14
Clean up ee4j #14
Conversation
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Added automatic module name
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Changed groupId and artifactId. Fixes #10 (EE4J)
Changed groupId and artifactId. Fixes #10 (master)
cc @ggam |
pom.xml
Outdated
<parent> | ||
<groupId>org.eclipse.ee4j</groupId> | ||
<artifactId>project</artifactId> | ||
<version>1.0</version> | ||
<version>1.0.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.0.2 is the latest. Please update.
pom.xml
Outdated
<groupId>org.glassfish.build</groupId> | ||
<artifactId>spec-version-maven-plugin</artifactId> | ||
<version>1.2</version> | ||
<version>1.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.5 is the version you need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments in pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the changes that have been suggested by Dmitry, rest seem to be similar to the cleanup in master.
License plug-in was adding CCDL license. GPG is now in parent pom Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Merges cleanup and spec fixes from master branch