Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ee4j #14

Merged
merged 21 commits into from
Oct 9, 2018
Merged

Clean up ee4j #14

merged 21 commits into from
Oct 9, 2018

Conversation

arjantijms
Copy link
Contributor

Merges cleanup and spec fixes from master branch

ggam and others added 20 commits September 8, 2018 11:02
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Changed groupId and artifactId. Fixes #10 (EE4J)
Changed groupId and artifactId. Fixes #10 (master)
@arjantijms
Copy link
Contributor Author

cc @ggam

pom.xml Outdated
<parent>
<groupId>org.eclipse.ee4j</groupId>
<artifactId>project</artifactId>
<version>1.0</version>
<version>1.0.1</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.2 is the latest. Please update.

pom.xml Show resolved Hide resolved
pom.xml Outdated
<groupId>org.glassfish.build</groupId>
<artifactId>spec-version-maven-plugin</artifactId>
<version>1.2</version>
<version>1.3</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.5 is the version you need.

pom.xml Show resolved Hide resolved
m0mus
m0mus previously requested changes Oct 7, 2018
Copy link

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in pom.xml

Copy link
Contributor

@yaminikb yaminikb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changes that have been suggested by Dmitry, rest seem to be similar to the cleanup in master.

License plug-in was adding CCDL license.
GPG is now in parent pom

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@arjantijms arjantijms dismissed m0mus’s stale review October 9, 2018 20:45

Feedback addressed

@arjantijms arjantijms merged commit 678ea37 into jakartaee:EE4J_8 Oct 9, 2018
@arjantijms arjantijms deleted the clean-up-ee4j branch June 29, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants