Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/src/main/java/tck/arquillian/protocol/common/TsTestPropsBuilder.java is setting wrong test_classname property for ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest #133

Closed
scottmarlow opened this issue Aug 29, 2024 · 1 comment
Assignees

Comments

@scottmarlow
Copy link
Member

Instead of setting "test_classname" property to "ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest" we seem to be setting it to the super class ee.jakarta.tck.persistence.core.EntityGraph.Client.

Currently, we set via:

        // The vehicle harness operates on the legacy CTS superclass of the Junit5 class.
        // unless the Junit5 test class directly extends the EETest/ServiceEETest class.
        if(isAbstract(testSuperclass)) {
            props.setProperty("test_classname", testClass.getName());
        } else {
            props.setProperty("test_classname", testSuperclass.getName());
        }

For ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest, we should use the testClass

@starksm64
Copy link
Member

That is what is required for most tests and the generated test class is really just a shell that adds the junit test annotations and arquillian deployment method. The real test logic is still in the base class for these tests. With the jpa refactoring, I guess that is not the case. I'll look at the ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants