Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce -IgnoreJDKClasses option for ignoring JDK classes and treat (legacy) -IgnoreJDKClass [jdkclass] option the same as -IgnoreJDKClasses #39

Closed
scottmarlow opened this issue Jun 28, 2024 · 2 comments

Comments

@scottmarlow
Copy link
Member

scottmarlow commented Jun 28, 2024

If -IgnoreJDKClasses is specified, JDK classes will be ignored when testing/checking signatures.

With this change, we will also treat the following options the same as -IgnoreJDKClasses:

  • IgnoreJDKClass javax.blah
  • IgnoreJDKClass

Migration note: Change from -IgnoreJDKClass (or -IgnoreJDKClass className sequences) to only specify -IgnoreJDKClasses.

@scottmarlow
Copy link
Member Author

I'm thinking that we will release a new sigtest release that ignores the IgnoreJDKClass (whether java class names are specified after or or not). Will see if that is possible.

@jamezp
Copy link
Contributor

jamezp commented Jun 28, 2024

FWIW I don't think we should remove or ignore the -IgnoreJDKClass, we just re-introduce the old behavior removed in #30. The same approach for #30 could be used, but instead of using -IgnoreJDKClass we should use -IgnoreJDKClasses.

@scottmarlow scottmarlow changed the title Introduce -IgnoreJDKClasses option and remove -IgnoreJDKClass Introduce -IgnoreJDKClasses option for ignoring JDK classes and treat (legacy) -IgnoreJDKClass [jdkclass] option the same as -IgnoreJDKClasses Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants