Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TCK tests for JDK 11 #213

Closed
scottmarlow opened this issue Apr 17, 2020 · 5 comments
Closed

Update TCK tests for JDK 11 #213

scottmarlow opened this issue Apr 17, 2020 · 5 comments

Comments

@scottmarlow
Copy link
Contributor

scottmarlow commented Apr 17, 2020

Need to update TCK tests as needed for JDK 11. See Java SE Version section:

Java SE Version

For inclusion in Jakarta EE 9, specification’s APIs MUST be compiled at the Java SE 8 source level. However, compatible implementations of the Jakarta EE 9 Web Profile and Full Profile MUST certify compatibility on Java SE 11. Compatible Implementations MAY additionally certify and support Java SE 8.

@scottmarlow
Copy link
Contributor Author

This looks like it may be a duplicate of issue#145 but will leave it open for now. If we do close it as a duplicate, we should update top level tracker issue #207 to refer to issue#145.

@scottmarlow
Copy link
Contributor Author

Another thing that we could do is determine whether its quicker to compare for the exact set of "javax..." sequences that we have to match against, versus matching against the set of "javax..." that we know do not match.

For example, the set of "javax..." sequences that we will match against, are shown in ASM TransformerImpl.java#L304, has 34 entries in the set. If the set of sequences that we don't want to match, has fewer entries (e.g. "javax.transaction.xa" + others), then its more efficient to only check for the smaller set of possible string values being passed to Class.forName().

@scottmarlow
Copy link
Contributor Author

@dmkavanagh
Copy link

Anything a newbie can do to help?

@scottmarlow
Copy link
Contributor Author

Excellent question @dmkavanagh
Once we know what the TCK failures are on JDK 11, help will be appreciated in updating (failing) tests to work on JDK 11 (as well as on JDK 8).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants