Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF]: JAXB string interning introduces major performance regression for webservices #805

Closed
Tomas-Kraus opened this issue Jan 13, 2011 · 9 comments

Comments

@Tomas-Kraus
Copy link
Member

See http://java.net/jira/browse/GLASSFISH-15559

Affected Versions

[2.2.3]

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
Reported by mmatula

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
Issue-Links:
blocks
GLASSFISH-15559

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
@pavelbucek said:
cased by fix for jersey issue http://java.net/jira/browse/JERSEY-320 (reopened)

patch (revert):

Index: runtime-fi/src/com/sun/xml/bind/v2/runtime/unmarshaller/FastInfosetConnector.java

— runtime-fi/src/com/sun/xml/bind/v2/runtime/unmarshaller/FastInfosetConnector.java (revision 3316)
+++ runtime-fi/src/com/sun/xml/bind/v2/runtime/unmarshaller/FastInfosetConnector.java (revision )
@@ -73,7 +73,7 @@

public FastInfosetConnector(StAXDocumentParser fastInfosetStreamReader,
XmlVisitor visitor)

{ - super(visitor); + super(new InterningXmlVisitor(visitor)); fastInfosetStreamReader.setStringInterning(true); this.fastInfosetStreamReader = fastInfosetStreamReader; }

applied in 2.2 branch (needed for another release), need to apply in trunk and 2.1 branch

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
snajper said:
Created 2.2.3 branch and merged the revert there.

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
snajper said:
The fix has been merged to 2.2.3 branch, so marking this as fixed. Waiting with the release until GF15536 root cause is found (may require jaxb changes as well).

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
Marked as fixed on Thursday, January 13th 2011, 9:44:58 pm

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
snajper said:
2.2.3U1 has been released.

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAXB-805

@Tomas-Kraus
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant