Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication and authorization example app #3823

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

NunuM
Copy link

@NunuM NunuM commented May 5, 2018

No description provided.

@jansupol
Copy link
Contributor

The pull request contains many new dependencies. Should ever the ip-validation check pass, we can start dealing with this PR after all outstanding Jersey CQs are filed.

@jansupol
Copy link
Contributor

jansupol commented May 31, 2018

An example for authentication/authorization can be interesting. The example, however, is rather large. If there are more examples like this coming, would be great, but my concern is that there would be more examples than Jersey. I am thinking to create a separate repo for these large examples....

@arjantijms
Copy link
Contributor

I am thinking to create a separate repo for these large examples..

What about creating a repo like the ones shown here https://github.com/javaee-samples ?

This org is available as well for that; https://github.com/jakartaee-samples

@jansupol
Copy link
Contributor

jansupol commented Jun 1, 2018

The javaee-samples are yet to be contributed, so jakartaee-samples will contain them....I like the idea of adding it there...

@NunuM
Copy link
Author

NunuM commented Jun 4, 2018

Hi, thanks for the reply. I already created a eclipse account and have agreed to eclipse CA. For what I have understood, I have to make other pull request to this rep (https://github.com/jakartaee-samples)? And Sign-off the git commit? I will provide also more documentation about the example with unit test as well.

@waynebeaton
Copy link

waynebeaton commented Jun 5, 2018

This org is available as well for that; https://github.com/jakartaee-samples

The org may be available, but the name infringes on the Jakarta EE trademark. Please check in with the Jakarta EE working group before moving this forward.

@jansupol
Copy link
Contributor

jansupol commented Jun 5, 2018

Sorry, I might have been wrong about the contribution of javaee-samples, they are likely not to be contributed, as they are not owned by Oracle, it must have been some other samples that I saw to be contributed...

Similarly, https://github.com/jakartaee-samples repository does not look like official jakartaee/ee4j github org, @waynebeaton can be right about the trademark, but then I do not know what name for the samples should be used to be descriptive enough and allowed.

There would be needed a repository to be created under https://github.com/jakartaee-samples where the example would be put. In case of choosing "Jersey" to part of the name, please use version "2" too, Jersey 3 seems to bring incompatibilities later introduced in JAX-RS 3.0.

Yes, please Sign-off the git commit.

@waynebeaton
Copy link

I didn't say no, but rather that there are rules for using the trademarks. Be sure to check with the trademark usage guidelines.

@arjantijms
Copy link
Contributor

arjantijms commented Jun 5, 2018

I didn't say no, but rather that there are rules for using the trademarks. Be sure to check with the trademark usage guidelines.

I will do that, but perhaps it would be an option to just transfer the ownership of that org to Eclipse to make it 'official'? I basically parked the name so someone else wouldn't be able to take it, but I've no particular need or wish to own it.

@waynebeaton
Copy link

I will do that, but perhaps it would be an option to just transfer the ownership of that org to Eclipse to make it 'official'? I basically parked the name so someone else wouldn't be able to take it, but I've no particular need or wish to own it.

Send a note to emo@eclipse.org with a request to use it and I'll sort it out. In the meantime, I strongly recommend that the namespace not be used.

@arjantijms
Copy link
Contributor

Send a note to emo@eclipse.org with a request to use it and I'll sort it out. In the meantime, I strongly recommend that the namespace not be used.

Perfect, I'll do that. Thanks!

@jansupol
Copy link
Contributor

jansupol commented Apr 9, 2019

There is a discussion about creating Jakarta EE samples, this one maybe could be there, too

@NunuM
Copy link
Author

NunuM commented Apr 11, 2019

@jansupol

Hi, what can I do for make this example available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants