Allow for having CDI on pure Jersey Client without Jersey Server #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dependencies Signed-off-by: jansupol <jan.supol@oracle.com>
jGauravGupta
approved these changes
Jan 21, 2021
jbescos
approved these changes
Jan 21, 2021
| */ | ||
| public static void bindProviders(ComponentBag componentBag, | ||
| RuntimeType constrainedTo, | ||
| Set<Class<?>> registeredClasses, | ||
| InjectionManager injectionManager) { | ||
| InjectionManager injectionManager, | ||
| Collection<ComponentProvider> componentProviders) { |
There was a problem hiding this comment.
As this method is public it is possible that it is already referenced by user code. Shouldn't we duplicate this method with previous arguments?.
There was a problem hiding this comment.
The general contract is that an internal package can be a subject of change. But yes, adding an extra method won't hurt.
Signed-off-by: jansupol <jan.supol@oracle.com>
senivam
approved these changes
Jan 26, 2021
This was referenced Jun 26, 2021
Merged
This was referenced Jul 6, 2021
This was referenced Aug 5, 2021
This was referenced Aug 29, 2021
This was referenced Apr 17, 2022
This was referenced May 3, 2022
Closed
1 task
Closed
1 task
1 task
This was referenced Oct 19, 2022
Closed
1 task
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
1 task
This was referenced Nov 30, 2023
1 task
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jansupol jan.supol@oracle.com