Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create a connector multiple times for each rx() call #4705

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Do not create a connector multiple times for each rx() call #4705

merged 1 commit into from
Feb 11, 2021

Conversation

jansupol
Copy link
Contributor

Priority is to use @ClientAsyncExecutor annotated ExecutorServiceProvider

Signed-off-by: jansupol jan.supol@oracle.com

@jansupol
Do not create a connector multiple times for each rx() call
51e2b10 
Priority is to use @ClientAsyncExecutor annotated ExecutorServiceProvider

Signed-off-by: jansupol <jan.supol@oracle.com>
@jansupol
Copy link
Contributor Author

The change from request().getClientConfig().executorService(provided); to ((ClientConfig) request().getConfiguration()).executorService(provided); itself causes the Connector is not recreated, as it keeps the inner State.

The other JerseyInvocation changes prioritize user provided @ClientAsyncExecutor annotated ExecutorServiceProvider over another user provided ExecutorServiceProvider.

@jansupol
Copy link
Contributor Author

jansupol commented Feb 3, 2021

Fixes #4683

@jansupol jansupol merged commit d956c52 into eclipse-ee4j:master Feb 11, 2021
@jansupol jansupol deleted the j4683 branch February 11, 2021 16:24
@jansupol jansupol self-assigned this Feb 11, 2021
@jansupol jansupol added this to the 2.34 milestone Feb 11, 2021
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Merged
Merged
Open
This was referenced Jul 6, 2021
Merged
Closed
This was referenced Aug 5, 2021
Merged
Merged
Closed
Closed
Closed
Closed
This was referenced Aug 29, 2021
Closed
Closed
This was referenced Aug 30, 2021
Closed
Merged
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@renovate renovate bot mentioned this pull request Jun 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 6, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
This was referenced Oct 19, 2022
Closed
Closed
@renovate renovate bot mentioned this pull request Dec 22, 2022
Closed
1 task
This was referenced Feb 11, 2023
Merged
Closed
@renovate renovate bot mentioned this pull request Mar 23, 2023
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 26, 2023
Open
This was referenced May 11, 2023
Open
Open
This was referenced Jun 15, 2023
Merged
Merged
This was referenced Jun 26, 2023
Closed
Open
This was referenced Jul 6, 2023
Open
Open
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
This was referenced Nov 30, 2023
Closed
Closed
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 24, 2024
Open
1 task
This was referenced Apr 13, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbescos jbescos jbescos approved these changes

@senivam senivam senivam approved these changes

Assignees

@jansupol jansupol

Labels
None yet
Projects
None yet
Milestone
2.34
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jansupol @jbescos @senivam