Support custom parameter types with Optional<T>
#4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
approved these changes
Jul 8, 2021
This was referenced Sep 6, 2021
This was referenced Sep 6, 2021
1 task
1 task
1 task
Closed
1 task
Closed
1 task
1 task
This was referenced Oct 19, 2022
Closed
1 task
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
1 task
This was referenced Nov 30, 2023
1 task
This was referenced Apr 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OptionalProvider(ParamConverterProvider) introduced in #4690 didn't support custom parameter types wrapped in anOptional<T>but only the types implemented inorg.glassfish.jersey.internal.inject.ParamConverters.This PR adds support for arbitrary parameter types by looking up the parameter converter providers via
InjectionManager.Refs #3087
Refs #4651
Refs dropwizard/dropwizard#3969
Closes #4798