Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.sun.org.apache.xml.internal #4812

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Jun 24, 2021

Currently when you compile jersey/ext/wadl-doclet with JDK 11+ it gets the next error:

[ERROR] /C:/Projects/Jersey/2x/ext/wadl-doclet/src/main/java/org/glassfish/jersey/wadl/doclet/DocletUtils.java:[20,39] package com.sun.org.apache.xml.internal.serialize is not visible
[ERROR]   (package com.sun.org.apache.xml.internal.serialize is declared in module java.xml, but module wadl.doclet does not read it)

This PR is about removing that com.sun.org.apache.xml.internal.serialize.

There is one module in Jersey that tests wadl-doclet in jersey/examples/extended-wadl-webapp and it generates the resourcedoc.xml. I am attaching both, with and without my changes.

I set this as a draft because in my computer I am getting one error running the tests that seems to be unrelated:
java.io.IOException: Error resolving artifact org.ops4j.pax.exam:pax-exam-inject:jar:4.13.1: Could not transfer artifact org.ops4j.pax.exam:pax-exam-inject:jar:4.13.1 from/to central (http://repo1.maven.org/maven2/): Failed to transfer file: http://repo1.maven.org/maven2/org/ops4j/pax/exam/pax-exam-inject/4.13.1/pax-exam-inject-4.13.1.jar. Return code is: 501 , ReasonPhrase:HTTPS Required.

I will change it to ready for review once Travis or Jenkins shows successful results.

@jbescos jbescos marked this pull request as draft June 24, 2021 13:34
@jbescos
Copy link
Member Author

jbescos commented Jun 24, 2021

Generated in jersey/examples/extended-wadl-webapp/target/classes/resourcedoc.xml it contains the file created with and without my changes.
resourcedoc.zip

@jbescos jbescos marked this pull request as ready for review June 25, 2021 07:16
@jbescos
Copy link
Member Author

jbescos commented Jun 25, 2021

After updating the version pax.exam.version I don't get the maven error, so it is possible to run the tests locally and it is working.

@jbescos jbescos requested review from jansupol and senivam June 25, 2021 07:16
@jbescos jbescos force-pushed the docletRefactoring branch 2 times, most recently from 2830a98 to 53c5032 Compare July 2, 2021 06:23
@senivam
Copy link
Contributor

senivam commented Jul 2, 2021

CQ #23575 resolved

@jbescos jbescos force-pushed the docletRefactoring branch 3 times, most recently from 02e2825 to 3309d16 Compare July 21, 2021 05:59
jbescos and others added 3 commits July 21, 2021 13:09
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
senivam and others added 2 commits July 21, 2021 16:11
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
OSGi example bundle fix

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jansupol jansupol added this to the 2.36 milestone Jul 26, 2021
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants