-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netty Connector doesn't support Followredirects #5048
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
...tty-connector/src/test/java/org/glassfish/jersey/netty/connector/FollowRedirectsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /* | ||
| * Copyright (c) 2022 Oracle and/or its affiliates. All rights reserved. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Eclipse Public License v. 2.0, which is available at | ||
| * http://www.eclipse.org/legal/epl-2.0. | ||
| * | ||
| * This Source Code may also be made available under the following Secondary | ||
| * Licenses when the conditions for such availability set forth in the | ||
| * Eclipse Public License v. 2.0 are satisfied: GNU General Public License, | ||
| * version 2 with the GNU Classpath Exception, which is available at | ||
| * https://www.gnu.org/software/classpath/license.html. | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 | ||
| */ | ||
|
|
||
| package org.glassfish.jersey.netty.connector; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| import java.net.URI; | ||
| import java.util.logging.Logger; | ||
|
|
||
| import javax.ws.rs.GET; | ||
| import javax.ws.rs.Path; | ||
| import javax.ws.rs.client.Client; | ||
| import javax.ws.rs.client.ClientBuilder; | ||
| import javax.ws.rs.client.WebTarget; | ||
| import javax.ws.rs.core.Application; | ||
| import javax.ws.rs.core.Response; | ||
|
|
||
| import org.glassfish.jersey.client.ClientConfig; | ||
| import org.glassfish.jersey.client.ClientProperties; | ||
| import org.glassfish.jersey.logging.LoggingFeature; | ||
| import org.glassfish.jersey.server.ResourceConfig; | ||
| import org.glassfish.jersey.test.JerseyTest; | ||
| import org.junit.Test; | ||
|
|
||
| public class FollowRedirectsTest extends JerseyTest { | ||
|
|
||
| private static final Logger LOGGER = Logger.getLogger(FollowRedirectsTest.class.getName()); | ||
| private static final String REDIRECT_URL = "http://localhost:9998/test"; | ||
|
|
||
| @Path("/test") | ||
| public static class RedirectResource { | ||
| @GET | ||
| public String get() { | ||
| return "GET"; | ||
| } | ||
|
|
||
| @GET | ||
| @Path("redirect") | ||
| public Response redirect() { | ||
| return Response.seeOther(URI.create(REDIRECT_URL)).build(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected Application configure() { | ||
| ResourceConfig config = new ResourceConfig(RedirectResource.class); | ||
| config.register(new LoggingFeature(LOGGER, LoggingFeature.Verbosity.PAYLOAD_ANY)); | ||
| return config; | ||
| } | ||
|
|
||
| @Override | ||
| protected void configureClient(ClientConfig config) { | ||
| config.property(ClientProperties.FOLLOW_REDIRECTS, false); | ||
| config.connectorProvider(new NettyConnectorProvider()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDoFollow() { | ||
| final URI u = target().getUri(); | ||
| ClientConfig config = new ClientConfig().property(ClientProperties.FOLLOW_REDIRECTS, true); | ||
| config.connectorProvider(new NettyConnectorProvider()); | ||
| Client c = ClientBuilder.newClient(config); | ||
| WebTarget t = c.target(u); | ||
| Response r = t.path("test/redirect") | ||
| .request().get(); | ||
| assertEquals(200, r.getStatus()); | ||
| assertEquals("GET", r.readEntity(String.class)); | ||
| c.close(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDoFollowPerRequestOverride() { | ||
| WebTarget t = target("test/redirect"); | ||
| t.property(ClientProperties.FOLLOW_REDIRECTS, true); | ||
| Response r = t.request().get(); | ||
| assertEquals(200, r.getStatus()); | ||
| assertEquals("GET", r.readEntity(String.class)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDontFollow() { | ||
| WebTarget t = target("test/redirect"); | ||
| assertEquals(303, t.request().get().getStatus()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDontFollowPerRequestOverride() { | ||
| final URI u = target().getUri(); | ||
| ClientConfig config = new ClientConfig().property(ClientProperties.FOLLOW_REDIRECTS, true); | ||
| config.connectorProvider(new NettyConnectorProvider()); | ||
| Client client = ClientBuilder.newClient(config); | ||
| WebTarget t = client.target(u); | ||
| t.property(ClientProperties.FOLLOW_REDIRECTS, false); | ||
| Response r = t.path("test/redirect").request().get(); | ||
| assertEquals(303, r.getStatus()); | ||
| client.close(); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javax.ws.rs.core.HttpHeaders.Location