Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grizzly] Expose start argument while providing parentContext #5101

Merged

Conversation

Menecats
Copy link
Contributor

Exposes the start argument in the createHttpServer method to allow creating a non-started server.

This is necessary when wanting to register additional addons on the server listener before starting it.

Example:

[...]

final HttpServer server = GrizzlyHttpServerFactory.createHttpServer(uri, resource, serviceLocator, false);

final WebSocketAddOn addon = new WebSocketAddOn();
server.getListeners().forEach(l -> l.registerAddOn(addon));

WebSocketEngine.getEngine().register(contextPath, "/ws", wsManager);

[...]

@jansupol
Copy link
Contributor

jansupol commented Aug 1, 2022

@Menecats Please update the copyright year to 2022 in the file.

Can you please also change @since 3.1 to 2.37 (master branch)?

@senivam senivam merged commit da45922 into eclipse-ee4j:master Aug 2, 2022
@senivam senivam added this to the 2.37 milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants