Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test issues #5137

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Fix test issues #5137

merged 2 commits into from
Sep 5, 2022

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Aug 29, 2022

I was not able to reproduce it, but it looks some users are having issues with a couple of tests.

@jansupol it would be good if you can run both tests and provide me feedback about the results.

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@@ -16,13 +16,17 @@

package org.glassfish.jersey.tests.integration.jersey4697;

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import static org.junit.Assert.assertEquals;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest version of the PR there are many redundant imports. Could you please clean them out?

And those imports, which are already in place (before any changes) should not be reformatted because when it comes to merges, reformatting brings unnecessary conflicts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see notes in the code

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@senivam senivam merged commit fc63a05 into eclipse-ee4j:master Sep 5, 2022
@senivam senivam added this to the 2.37 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants