Prevent blowing connections number for reoccurring SSLContextFatories #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
changed the title
jansupol
force-pushed
the
keep-alive.default.connector
branch
from
db9db38
to
40cd194
Compare
|
Relates to #5647 |
…nstances Signed-off-by: jansupol <jan.supol@oracle.com>
jansupol
force-pushed
the
keep-alive.default.connector
branch
from
40cd194
to
645da07
Compare
jbescos
reviewed
Jun 17, 2024
| connector.secureConnection((JerseyClient) client, (HttpURLConnection) urlConnection); | ||
| secondRequestFactory = factoryHolder.get().hashCode(); | ||
|
|
||
| MatcherAssert.assertThat(firstRequestFactory, Matchers.equalTo(secondRequestFactory)); |
There was a problem hiding this comment.
Can't we compare factories instead of hashCode?. It is unlikely, but two different instances could have same hashCode.
jbescos
approved these changes
Jun 17, 2024
Signed-off-by: jansupol <jan.supol@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.