ResponseWriter#writeResponseStatusAndHeaders drops some redundant code #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A condition with identical branches. Found this when looking at: 4977fec Author: jansupol <jan.supol@oracle.com> Date: Mon Feb 21 18:23:20 2022 +0100 Replace removed API in Servlet 6
rw7
force-pushed
the
ResponseWriterReasonPhrase
branch
from
e06de9d
to
01c74d6
Compare
senivam
approved these changes
Jun 25, 2024
|
Looks good, but to be merged the ECA should be signed. |
|
I just signed the ECA. Actually I tried to do this yesterday, but creating an account did not work. Now it did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A condition with identical branches.
Found this when looking at:
4977fec
Author: jansupol jan.supol@oracle.com
Date: Mon Feb 21 18:23:20 2022 +0100
Replace removed API in Servlet 6