Add testsuite task for Websphere Liberty #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 14, 2020 09:37
see: #155 To ensure Krazo works on Liberty as well as on TomEE in any case, a new task for Travis is added. The reason for this is, that Liberty behaves different e.g. when setting classes in the JAX-RS application which leads to a lot of bug reports and questions. Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
see: #155 Signed-off-by: Erdle, Tobias <tobias.erdle@innoq.com>
chkal
approved these changes
Feb 15, 2020
| @@ -259,7 +259,7 @@ | |||
| <dependency> | |||
| <groupId>io.openliberty.arquillian</groupId> | |||
| <artifactId>arquillian-liberty-managed</artifactId> | |||
| <version>1.0.3</version> | |||
| <version>1.0.6</version> | |||
| unzip wlp.zip | ||
| cp .travis/wlp-server-template.xml wlp/templates/servers/defaultServer/server.xml | ||
| LIBERTY_HOME="$( cd ./wlp/ && pwd )" | ||
| source .travis/install-liberty.sh |
There was a problem hiding this comment.
Just a side note: At some point it would be great if we could improve and unify all the scripts that are used to start containers and run the various test suites. Not sure yet how to do that. I just wanted to note, that tests.sh is getting huge and difficult to maintain.
|
I'm not sure if we need a CQ here, as we have this dependency already in
the `tck` module and I just changed the bugfix version.
And I agree that we should clean up and unify as far as possible how we run
our tests etc.
Christian Kaltepoth <notifications@github.com> schrieb am Sa., 15. Feb.
2020, 09:12:
… ***@***.**** approved this pull request.
Awesome! Looks great! +1 for merging if we have all CQs in place!
------------------------------
In tck/pom.xml
<#156 (comment)>:
> @@ -259,7 +259,7 @@
<dependency>
<groupId>io.openliberty.arquillian</groupId>
<artifactId>arquillian-liberty-managed</artifactId>
- <version>1.0.3</version>
+ <version>1.0.6</version>
Do we need a CQ for this?
------------------------------
In .travis/tests.sh
<#156 (comment)>:
> @@ -113,10 +112,7 @@ elif [ "${1}" == "tck-tomee" ]; then
elif [ "${1}" == "tck-liberty" ]; then
- curl -L -s -o wlp.zip "${LIBERTY_URL}"
- unzip wlp.zip
- cp .travis/wlp-server-template.xml wlp/templates/servers/defaultServer/server.xml
- LIBERTY_HOME="$( cd ./wlp/ && pwd )"
+ source .travis/install-liberty.sh
Just a side note: At some point it would be great if we could improve and
unify all the scripts that are used to start containers and run the various
test suites. Not sure yet how to do that. I just wanted to note, that
tests.sh is getting huge and difficult to maintain.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#156?email_source=notifications&email_token=AKNSNUUSWXEDDKYE6263EHLRC6PWBA5CNFSM4KVDMAT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVVP6BA#pullrequestreview-359333636>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKNSNUVBMOAR47ZPYGLOQ7DRC6PWBANCNFSM4KVDMATQ>
.
|
Ah, ok. I just checked our wiki page about CQs and it looks like we don't need CQs for patch releases. So let's merge this now! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #155
To ensure Krazo works on Liberty as well as on TomEE in any case, a new task for Travis is added.
The reason for this is, that Liberty behaves different e.g. when setting classes in the JAX-RS
application which leads to a lot of bug reports and questions.
Signed-off-by: Erdle, Tobias tobias.erdle@innoq.com