Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HttpCommunicationWrapper for Liberty Jakarta EE 10 #365

Merged

Conversation

mthmulders
Copy link
Contributor

Follow-up on #364. This change gets Krazo working on OpenLiberty 22.0.0.13-beta with Jakarta EE 10.

I have added the HttpCommunicationWrapper next to the existing one, introduced in #288. I don't know if they should live together, or if this one should replace the previous one. When living together, I'm not sure about the priority of one vs. the other.

@erdlet
Copy link
Member

erdlet commented Dec 29, 2022

Thanks for the contribution! I try to run the code against the testsuite within the next days to check if / how we should proceed with the two unwrapper implementations. The code itself looks good👍🏻

@chkal
Copy link
Contributor

chkal commented Dec 31, 2022

@mthmulders Thanks a lot for sharing this solution. It would be great if we could improve compatibility with OpenLiberty which such a workaround. Also, it looks to me as if the actual root cause should be fixed on the OpenLiberty side. Maybe we are lucky and OpenLiberty/open-liberty#23774 will be fixed soon.

@erdlet
Copy link
Member

erdlet commented Feb 5, 2023

@mthmulders sorry for the delay. I had to get the testsuite for OL working again. But it seems that this workaround is working great and as soon as the testsuite is merged to master we can merge this PR as well. There will be still test failures, but those are related to some OL internal problems or issues we still have to investigate.

@erdlet erdlet added this to the 3.1.0 milestone Feb 5, 2023
@erdlet erdlet merged commit baed73a into eclipse-ee4j:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants