BUG 35047999: Show Server Error in faultString instead of error details. #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com>
lukasj
reviewed
May 31, 2023
jaxws-ri/runtime/rt/src/test/java/com/sun/xml/ws/fault/SOAPFaultBuilderTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com>
lukasj
requested changes
Jun 9, 2023
There was a problem hiding this comment.
-
new private method
createFaultString(String)::String(or similar) responsible for altering existing fault string if necessary should be added toSOAPFaultBuilderand existingcreateSOAP1?Faultmethods should be updated to send the fault string through this new one -
the pattern to test statics/system props in this case should be:
boolean oldValue = SOAPFaultBuilder.isCaptureExceptionMessage();
try {
SOAPFaultBuilder.setCaptureExceptionMessage(...);
} finally {
SOAPFaultBuilder.setCaptureExceptionMessage(oldValue);
}
jaxws-ri/runtime/rt/src/main/java/com/sun/xml/ws/fault/SOAPFaultBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com>
|
Changes done. Kindly review. |
lukasj
reviewed
Jun 13, 2023
| @@ -501,6 +506,9 @@ private static Message createSOAP12Fault(SOAPVersion soapVersion, Throwable e, O | |||
| } | |||
| } | |||
|
|
|||
| faultString = setFaultStringToServerError(faultString); | |||
There was a problem hiding this comment.
changing passed in argument is not good idea, even though java is pass-by-value language. Should use a different variable if at all required (...likely not in this case)
lukasj
reviewed
Jun 13, 2023
jaxws-ri/runtime/rt/src/main/java/com/sun/xml/ws/fault/SOAPFaultBuilder.java
Outdated
Show resolved
Hide resolved
lukasj
reviewed
Jun 13, 2023
jaxws-ri/runtime/rt/src/test/java/com/sun/xml/ws/fault/SOAPFaultBuilderTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com>
|
Changes done. Please review. |
Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com>
lukasj
reviewed
Jun 21, 2023
jaxws-ri/runtime/rt/src/main/java/com/sun/xml/ws/fault/SOAP12Fault.java
Outdated
Show resolved
Hide resolved
jaxws-ri/runtime/rt/src/main/java/com/sun/xml/ws/fault/SOAPFaultBuilder.java
Outdated
Show resolved
Hide resolved
jaxws-ri/runtime/rt/src/main/java/com/sun/xml/ws/fault/SOAPFaultBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com>
Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com>
|
Pull request updated. Please have a look. |
Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com>
lukasj
pushed a commit
to lukasj/metro-jax-ws
that referenced
this pull request
Oct 17, 2023
…ls. (eclipse-ee4j#648) Signed-off-by: Himanshu Ranjan <himanshu.ranjan@oracle.com> (cherry picked from commit 9203195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, SOAP response packet contains faultString which contains detailed error message in case of any SOAP Fault.
The customer has a requirement where they do not want any exception messages to be displayed in the faultString for security concerns.
For the same reason, a fix was introduced for BUG34600318 where a new system property com.sun.xml.ws.fault.SOAPFaultBuilder.captureExceptionMessage=false
has been added to simulate customer intended behavior.
This bug is intended to address the same issue but to include all possible cases which has been missed in the previous BUG34600318.
Added more testcases in file:
./jaxws-ri/runtime/rt/src/test/java/com/sun/xml/ws/fault/SOAPFaultBuilderTest.java
Signed-off-by: Himanshu Ranjan himanshu.ranjan@oracle.com