Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f:ajax silently ignores input fields with html5 input types which are text #2536

Closed
ren-zhijun-oracle opened this issue Oct 6, 2012 · 15 comments
Assignees

Comments

@ren-zhijun-oracle
Copy link
Contributor

If using custom components implementing HTML5 input types (number,date,tel,email,etc) using an f:ajax for submit will silent ignore the inputs.

The following input types are submitted as text

date
datetime
datetime-local
email
month
number
range
search
tel
time
url
week
color

http://www.w3schools.com/html/html5_form_input_types.asp

Also see - https://issues.jboss.org/browse/RF-12524

Affected Versions

[2.1.7]

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Reported by codylerum

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Issue-Links:
is related to
JAVASERVERFACES-2513

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Was assigned to rogerk

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
@manfredriem said:
Please attach a sample project which includes the sources of your custom component and demonstrates the problem. Thanks!

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
codylerum said:
I'll try and throw something together next week.

In the meantime the issue is here - https://github.com/jboss/mojarra/blob/svn/trunk/jsf-api/src/main/resources/jsf.js#L2381

The jsf.getViewState only adds inputs of certain types

text
password
hidden
textarea
select-one
select-multiple
checkbox
radio

All others are ignored.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
@edburns said:
There are two problems here:

1. The merge from

https://svn.java.net/svn/mojarra~svn/branches/SPEC_1111_PROTOTYPE_BRANCH

to the trunk, which partially implemented JAVASERVERFACES_SPEC_PUBLIC-1111, is missing the changes to jsf.js. This is handled by issue #2517.

2. Once #2517 is fixed, this issue, #2536, will cover the backporting of that change to the 2.1 code line.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
codylerum said:
Perfect

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Changes.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
As i turns out, it looks like HTMLUnit does not support HTML5, so I will have to come up with another test.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Changes.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
File: changebundle-2532.txt
Attached By: rogerk

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
rogerk said:
Committed to MOJARRA_2_1X_ROLLING:
Sending jsf-api/src/main/resources/jsf.js
Adding test/agnostic/renderKit/basic/src/main/webapp/issue2532.xhtml
Adding test/agnostic/renderKit/basic/src/test/java/com/sun/faces/test/agnostic/renderKit/basic/Issue2532IT.java
Transmitting file data ...
Committed revision 10899.

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
Marked as fixed on Tuesday, October 23rd 2012, 9:20:46 am

@ren-zhijun-oracle
Copy link
Contributor Author

@javaserverfaces Commented
This issue was imported from java.net JIRA JAVASERVERFACES-2532

@ren-zhijun-oracle
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants