New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't log expected NoSuchMethodException after it's caught. #4545
Don't log expected NoSuchMethodException after it's caught. #4545
Conversation
fae6162
to
c7f4c91
Compare
Can anyone review this change please? |
Red Hat JBoss Enterprise Application users have reported that when you turn on TRACE logging for javax.enterprise.resource then you can notice NoSuchMethodException during JSF app deployment. The problem is that org.jboss.as.jsf.injection.JandexAnnotationProvider doesn't have corresponding constructor (with two params - javax.servlet.ServletContext, com.sun.faces.spi.AnnotationProvider) see more about issue report in forum discussion https://developer.jboss.org/message/960985 and WFLY community issue in https://issues.jboss.org/browse/WFLY-6918 |
9bfca83
to
f08091a
Compare
Signed-off-by: Chao Wang <chaowan@redhat.com>
f08091a
to
6d1d620
Compare
Can an admin review this PR so that we can resolve it? If the code is intended to handle multiple method signatures, then it should not be logging exceptions such as NoSuchMethodException which suggests an error occurred. Better trace logging if you want to know which method it invoke would be to log that the method signature you ended up invoking. |
@arjantijms @juneau001 can any of you take a look at this PR please? |
Review pinging again. Can this be merged, please? |
Thanks for your patience and pinging again, we're currently very busy with the Jakarta EE 8 release, but this (and a number of outstanding other Mojarra PRs) will have the very next priority. Should be within a few days. At a glance the PR seems fine. |
Thanks @arjantijms! |
Hi, Any chance this can be merged? |
WildFly and Red Hat JBoss Enterprise Application users reports issue in https://developer.jboss.org/message/960985 and https://issues.jboss.org/browse/WFLY-6918
When a AnnotationProvider implementation doesn't have a two parameters(javax.servlet.ServletContext, com.sun.faces.spi.AnnotationProvider) which is optional,
ServiceFactoryUtils will log a confusing NoSuchMethodException when WildFly and Red Hat JBoss Enterprise Application with a TRACE logger level enabled.
This change stop logging for expected NoSuchMethodException after it's caught.
Downstream 2.3 branch PR: #4590