Fix issue 4551, don't compare class name and skip CDIValidator #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao Wang <chaowan@redhat.com>
|
Can anyone review this change please? |
This was referenced Apr 9, 2019
|
Red Hat JBoss Enterprise Application users have reported this issue where the @FacesValidator only invokes the first validator when it should invoke others such that it behaves the same as when configured via faces-config.xml , can someone please review the proposed changed to make the annotations work inline with the xml configuration ? |
|
If possible, please provide a test for this fix. It is standard practice to include a test that can be integrated into the test suite to prove the fix repairs the issue. We appreciate your time and contribution! |
Signed-off-by: Chao Wang <chaowan@redhat.com>
juneau001
approved these changes
Apr 29, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #4551