Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4509 Removed faulty context map clear and replaced with check #4621

Merged

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Aug 14, 2019

This is backport PR.

… with check

Signed-off-by: David Matejcek <dmatej@seznam.cz>
@dmatej dmatej force-pushed the backport-issue-4509-for-eclipse branch from 2133903 to 20b85f4 Compare August 14, 2019 09:51
@arjantijms
Copy link
Contributor

@dmatej That's a pretty well written section of code 😆

Thx!

@dmatej
Copy link
Contributor Author

dmatej commented Aug 14, 2019

You are the autor, but it seems that when I resolved conflicts git decided that now it is mine :D
In 2.2 backport for the original repo the cherrypick was without conflicts, so there we are both as autors :)

@arjantijms
Copy link
Contributor

You are the autor, but it seems that when I resolved conflicts git decided that now it is mine :D

Haha, it's fine ;)

@arjantijms arjantijms merged commit 8687eb9 into eclipse-ee4j:master Aug 14, 2019
@arjantijms arjantijms self-assigned this Aug 14, 2019
@dmatej dmatej deleted the backport-issue-4509-for-eclipse branch August 14, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants