Revert asm to 7.3.1 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1751cec. Signed-off-by: hs536 <sawamura.hiroki@fujitsu.com>
|
@russgold @smillidge |
|
My thought is we need to be consistent from a GlassFish perspective across the orb, HK2 etc for asm versions. So we either do this or update GlassFish and HK2 to 8.0.1? I suppose it depends whether we want JDK 14 support at release? |
|
In the latter case, some orb-gmbal-pfl modules also should be updated asm to 8.0.1. I suspect this commit is a minor mistake. |
smillidge
approved these changes
Jul 7, 2020
|
Sorry for bothering you but could I ask you to build it as staging? |
|
4.1.2-RC1 is on staging |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit 1751cec (*).
*) The commit was added on the PR #30
Update ASM to version 7 and remove included version.but asm has been updated to 8 instead of 7 even though pfl modules still use 7.3.1.
In addition, this update causes an OSGi error with the current HK2.
so, if there is no implementation reason, I'd like to revert this commit...
Signed-off-by: hs536 sawamura.hiroki@fujitsu.com