Leftover jdk11 issues

[russgold]

In correcting a problem with a previous pull request, I neglected to add these changes back. Although the merged pull request referenced the issues, it didn't actually fix them. So trying again: this should fix issues #48, #50, and #51.

[russgold]

I have now verified that the new ORB jars address the relevant issues raised for WLS on JDK11 and JDK12. I would like, therefore, to release the now-staged jars to maven central. The most important changes are a change to PFL to allow defining classes using an anchor class, as required by the module system (with a JDK8-compatible implementation), changes to the ORB to use the new method, and a fix to RMIC which handles some changes in JDK12 classes. What needs to happen next? Thanks, Russ

[bshannon]

Are you asking what mechanically needs to be done to actually release the jars?

Or are you asking what requirements must be met before you're allowed to release the jars?

For the former, it's mostly about setting up the right Jenkins jobs, which I believe we've
talked about previously.

For the latter, it's mostly about testing. Ideally there would be a standalone test suite for
the ORB, but lacking that the best test is probably to integrate the new version of the ORB
into a build of GlassFish, then test that build of GlassFish using the platform TCK, which
will test interoperability with the released version of GlassFish. I don't think we have a
convenient way to do that yet, but that's what we should work towards.

[russgold]

What I’ve done is to test WLS with the staged orb jars, and that works. Apparently, nobody had run the jenkins job to release the jars before, as the script simply didn’t work. I’m not a shell expert, but I believe I have it working. But I just received an emergency bug report for a change made eight(!) years ago, and I will see if I can get that addressed before the release.

…

On Apr 16, 2019, at 11:13 PM, Bill Shannon ***@***.***> wrote: Are you asking what mechanically needs to be done to actually release the jars? Or are you asking what requirements must be met before you're allowed to release the jars? For the former, it's mostly about setting up the right Jenkins jobs, which I believe we've talked about previously. For the latter, it's mostly about testing. Ideally there would be a standalone test suite for the ORB, but lacking that the best test is probably to integrate the new version of the ORB into a build of GlassFish, then test that build of GlassFish using the platform TCK, which will test interoperability with the released version of GlassFish. I don't think we have a convenient way to do that yet, but that's what we should work towards. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#56 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACL7YJq3tNd5wAQmG9-5JEn7vhZUXyU9ks5vhpFggaJpZM4csqDt>.