Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose EE 10 selection for Open Liberty #251

Merged
merged 2 commits into from Jun 4, 2023
Merged

Expose EE 10 selection for Open Liberty #251

merged 2 commits into from Jun 4, 2023

Conversation

scottkurz
Copy link
Contributor

@scottkurz scottkurz commented Apr 10, 2023 •
edited

@eclipse-starter-bot
Copy link

Can one of the admins verify this patch?

@scottkurz
Copy link
Contributor Author

The second commit in this PR is totally unrelated but thought I'd just tack it on here rather than a separate one.

@m-reza-rahman m-reza-rahman self-assigned this Apr 10, 2023
@scottkurz scottkurz marked this pull request as ready for review April 19, 2023 13:30
@scottkurz
Copy link
Contributor Author

The Open Liberty compatibility issues have been accepted and closed. Requesting a review now.

@scottkurz
Copy link
Contributor Author

Noting the issue for declaring compatibility on the website at jakartaee/jakarta.ee#1657

@m-reza-rahman
Copy link
Contributor

This looks good. Do you mind if we look to merging this after Kito's look and feel work is done? There are updates for Paraya and GlassFish as well actually (that I will take care of).

@scottkurz
Copy link
Contributor Author

This looks good. Do you mind if we look to merging this after Kito's look and feel work is done? There are updates for Paraya and GlassFish as well actually (that I will take care of).

Sure... I'm sure there's a separate process for releasing each of the archetype and UI updates... and this particular PR includes both types of updates, so don't expect it to be immediate. Thank you.

@scottkurz scottkurz force-pushed the openliberty-ee10-compliance branch from 1baa2e6 to bb84a55 Compare May 1, 2023 21:55
@scottkurz
Expose EE 10 selection for Open Liberty
9a5b305 
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
@scottkurz
For Open Liberty avoid plugin parm config to allow CLI override
714a918 
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
@scottkurz scottkurz force-pushed the openliberty-ee10-compliance branch from bb84a55 to 714a918 Compare May 1, 2023 21:56
@scottkurz
Copy link
Contributor Author

Rebased the text update

@jeyvison jeyvison merged commit 93ec884 into eclipse-ee4j:master Jun 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-reza-rahman m-reza-rahman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scottkurz @eclipse-starter-bot @m-reza-rahman @jeyvison