Add all positive cases for TomEE #303

jannahsherif · 2024-06-24T17:42:40Z

No description provided.

eclipse-starter-bot · 2024-06-24T17:46:04Z

Can one of the admins verify this patch?

.github/workflows/nightly.yml

m-reza-rahman

Please address review feedback.

jannahsherif · 2024-06-27T13:24:31Z

Hello I just committed my new changes. After reviewing the feedback I add docker support and added the deleted cases

m-reza-rahman

Please order by SE version (starting with the lowest), runtime/none (alphabetic, starting with none), EE version (starting with the lowest), profile (full, web, core), and Docker (no, yes).

So like this:

Run Archetype for EE 8 Web Profile, SE 8, Payara
Run Archetype for EE 8 Web Profile, SE 8, Payara, with Docker

Please order your part and the file overall - including existing cases. Confusing to read and evaluate otherwise for me.

m-reza-rahman · 2024-07-01T21:20:34Z

Please resolve conflicts with latest commits to master.

jannahsherif · 2024-07-02T14:42:26Z

Hello I tried implement the reviews and organizing the cases correctly

m-reza-rahman · 2024-07-02T14:46:17Z

At the bare minimum, the issue you need to resolve now are the conflicts before I can review again. Those will happen and are normal in a multi-developer project.

jannahsherif · 2024-07-02T15:22:20Z

hi i reviewed the conflicts

m-reza-rahman · 2024-07-02T15:29:36Z

OK. I will review if I have some time during the work week. Otherwise, may need to wait until the weekend.

m-reza-rahman

Please double check ordering/duplication. It is still incorrect. Check the latest successful merges for reference if needed.

m-reza-rahman

This PR should be focused on TomEE. Please remove changes related to WildFly.

m-reza-rahman · 2024-07-07T21:39:25Z

.github/workflows/nightly.yml

@@ -320,6 +346,8 @@ jobs:
      - name: Run Archetype for EE 8 Web Profile, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=web -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman · 2024-07-07T21:39:33Z

.github/workflows/nightly.yml

@@ -330,6 +358,8 @@ jobs:
      - name: Run Archetype for EE 10, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=full -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman · 2024-07-07T21:39:41Z

.github/workflows/nightly.yml

@@ -340,6 +370,8 @@ jobs:
      - name: Run Archetype for EE 10 Web Profile, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=web -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman · 2024-07-07T21:39:49Z

.github/workflows/nightly.yml

@@ -350,10 +382,12 @@ jobs:
      - name: Run Archetype for EE 10 Core Profile, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=core -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman · 2024-07-07T21:40:16Z

.github/workflows/nightly.yml

          rm -rf app/wildfly

      - name: Set up Java SE 17
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:40:42Z

.github/workflows/nightly.yml

@@ -497,12 +531,32 @@ jobs:
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=core -DjavaVersion=17 -Druntime="open-liberty" -Ddocker=yes -DoutputDirectory="app/open-liberty" -Dgoals="clean package"
          rm -rf app/open-liberty
-  
+


Why is this white space change needed?

m-reza-rahman · 2024-07-07T21:40:59Z

.github/workflows/nightly.yml

        with:
          distribution: "temurin"
          java-version: 11

      - name: Cache Maven packages
-        uses: actions/cache@v3
+        uses: actions/cache@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:41:04Z

.github/workflows/nightly.yml

      - name: Setup Java
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:41:09Z

.github/workflows/nightly.yml

  build-ui:
    runs-on: ubuntu-20.04
    steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:41:38Z

.github/workflows/nightly.yml

@@ -516,6 +570,8 @@ jobs:
      - name: Run Archetype for EE 8, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=full -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman · 2024-07-07T21:41:46Z

.github/workflows/nightly.yml

@@ -526,6 +582,8 @@ jobs:
      - name: Run Archetype for EE 8 Web Profile, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=web -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman · 2024-07-07T21:41:53Z

.github/workflows/nightly.yml

@@ -536,6 +594,8 @@ jobs:
      - name: Run Archetype for EE 10, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=full -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman · 2024-07-07T21:42:00Z

.github/workflows/nightly.yml

@@ -546,6 +606,8 @@ jobs:
      - name: Run Archetype for EE 10 Web Profile, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=web -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman · 2024-07-07T21:42:13Z

.github/workflows/nightly.yml

@@ -556,21 +618,22 @@ jobs:
      - name: Run Archetype for EE 10 Core Profile, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=core -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to TomEE.

m-reza-rahman

I have now added specific in-place feedback for you. Please address them. Then I can review hopefully one last time before merge.

jannahsherif · 2024-07-07T22:59:04Z

Thank you for the detailed explanation! I resolved all the conflicts but I am running into a problem with the space changes. If i remove the extra space it highlights it in red. If I readd it, it shows one line red then the one after green. How can i get it not be red or green?

m-reza-rahman · 2024-07-07T23:26:58Z

It looks honestly like you have some sync issues. What I suggest is closing this PR, saving aside your changes, forking fresh again, re-apply your changes, and then open a new PR. That might be easiest at this point.

jannahsherif added 3 commits June 24, 2024 20:11

testing nightly.yml

5e0d370

other extra testing nightly.yml

369f4fb

add all positive cases for tomee nightly.yml

4e88f9c

m-reza-rahman reviewed Jun 24, 2024

View reviewed changes

.github/workflows/nightly.yml Show resolved Hide resolved

m-reza-rahman requested changes Jun 24, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft June 24, 2024 18:12

Fixed the setup for adding positive classes nightly.yml

579202a

m-reza-rahman changed the title ~~Add all positive cases for tomee~~ Add all positive cases for TomEE Jun 26, 2024

Restored previous deleted case and added docker information nightly.yml

5c0c8d4

jannahsherif marked this pull request as ready for review June 27, 2024 13:23

m-reza-rahman requested changes Jun 27, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft June 27, 2024 23:49

removed "without docker" and organized the cases nightly.yml

f0a19fb

Merge branch 'master' into master

c800cf8

jannahsherif marked this pull request as ready for review July 2, 2024 15:01

m-reza-rahman requested changes Jul 2, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft July 2, 2024 19:23

jannahsherif added 2 commits July 4, 2024 14:54

latest nightly.yml

80d0890

Resolve ordering nightly.yml

1adacf6

jannahsherif marked this pull request as ready for review July 4, 2024 12:01

m-reza-rahman requested changes Jul 4, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft July 4, 2024 19:27

Original nightly

273f5ef

m-reza-rahman reviewed Jul 7, 2024

View reviewed changes

m-reza-rahman requested changes Jul 7, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft July 7, 2024 21:45

jannahsherif added 8 commits July 7, 2024 22:24

changes p1

0e473e0

changes p2

fb73740

changes p3

4ee49a2

changes p4

95166df

changes p5

5384b1d

changes p6

4a83ee2

changes p7

1b9d0d5

try

fb480e1

jannahsherif added 3 commits July 7, 2024 23:10

changes p9

9cf25f6

trial p2

3557e8a

Update nightly.yml

f613afc

jannahsherif closed this Jul 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add all positive cases for TomEE #303

Add all positive cases for TomEE #303

jannahsherif commented Jun 24, 2024

eclipse-starter-bot commented Jun 24, 2024

m-reza-rahman left a comment

jannahsherif commented Jun 27, 2024

m-reza-rahman left a comment

m-reza-rahman commented Jul 1, 2024

jannahsherif commented Jul 2, 2024

m-reza-rahman commented Jul 2, 2024

jannahsherif commented Jul 2, 2024

m-reza-rahman commented Jul 2, 2024

m-reza-rahman left a comment

m-reza-rahman left a comment

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman Jul 7, 2024

m-reza-rahman left a comment

jannahsherif commented Jul 7, 2024

m-reza-rahman commented Jul 7, 2024

Add all positive cases for TomEE #303

Add all positive cases for TomEE #303

Conversation

jannahsherif commented Jun 24, 2024

eclipse-starter-bot commented Jun 24, 2024

m-reza-rahman left a comment

Choose a reason for hiding this comment

jannahsherif commented Jun 27, 2024

m-reza-rahman left a comment

Choose a reason for hiding this comment

m-reza-rahman commented Jul 1, 2024

jannahsherif commented Jul 2, 2024

m-reza-rahman commented Jul 2, 2024

jannahsherif commented Jul 2, 2024

m-reza-rahman commented Jul 2, 2024

m-reza-rahman left a comment

Choose a reason for hiding this comment

m-reza-rahman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-reza-rahman left a comment

Choose a reason for hiding this comment

jannahsherif commented Jul 7, 2024

m-reza-rahman commented Jul 7, 2024