Add all positive cases for GlassFish runtime #304

adan-jawad · 2024-06-24T17:42:47Z

No description provided.

eclipse-starter-bot · 2024-06-24T17:46:03Z

Can one of the admins verify this patch?

m-reza-rahman

This is organized incorrectly. At the top level, there should be two jobs: one for the Archetype and one for the UI. For the Archetype, things should first be organized by Java SE version, corresponding to invocations with that version. For each Java SE version, tests should then be organized by runtime, Jakarta EE version, profile then Docker flag.

adan-jawad · 2024-06-27T13:27:02Z

Hello, I have added descriptions for docker support and organized the cases in the way specified. I have restored the old cases from the original file and have added my cases between the start and end comments for every java version for easy readability. I'll remove these comments once you review this.

m-reza-rahman

Please order by SE version (starting with the lowest), runtime/none (alphabetic, starting with none), EE version (starting with the lowest), profile (full, web, core), and Docker (no, yes).

So like this:

Run Archetype for EE 8 Web Profile, SE 8, Payara
Run Archetype for EE 8 Web Profile, SE 8, Payara, with Docker

Where Docker is really not supported (a warning is generated by the Archetype), we should not treat that as a "positive case". That's a negative case we need to test for later. GlassFish currently does not support Docker.

Please order your part and the file overall - including existing cases. Confusing to read and evaluate otherwise for me.

m-reza-rahman · 2024-07-01T21:20:06Z

Please resolve conflicts with latest commits to master.

adan-jawad · 2024-07-02T14:38:47Z

I am a bit confused. Do I delete the cases where docker is not supported, or do I just remove that from the description?

m-reza-rahman · 2024-07-02T14:43:27Z

For now, kindly remove the cases where Docker is not supported and set them aside. These need to be added later as explicitly tested negative cases.

m-reza-rahman · 2024-07-02T15:18:36Z

Please resolve all merge conflicts.

m-reza-rahman · 2024-07-02T15:47:31Z

I will review if I have some time during the work week. Otherwise, may need to wait until the weekend.

adan-jawad · 2024-07-02T15:52:07Z

I will review if I have some time during the work week. Otherwise, may need to wait until the weekend.

Sure.

m-reza-rahman · 2024-07-02T21:14:06Z

.github/workflows/nightly.yml

@@ -34,6 +34,9 @@ jobs:
      - name: Run Archetype for EE 8 Web Profile, SE 8
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=web -DjavaVersion=8 -DoutputDirectory=app -Dgoals="clean package"
+
+          rm -rf app  


Why is this needed?

m-reza-rahman · 2024-07-02T21:14:53Z

.github/workflows/nightly.yml

      - name: Run Archetype for EE 8, SE 8, GlassFish
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=full -DjavaVersion=8 -Druntime=glassfish -DoutputDirectory=app/glassfish -Dgoals="clean package"
          rm -rf app/glassfish

+
+      - name: Run Archetype for EE 8 Web Profile, SE 8, GlassFish 


This is a duplicate. Why is it needed?

m-reza-rahman · 2024-07-02T21:15:31Z

.github/workflows/nightly.yml

@@ -133,6 +144,10 @@ jobs:

      - name: Run Archetype for EE 8, SE 8, WildFly
        run: |
+


Why was this added?

m-reza-rahman · 2024-07-02T21:16:52Z

.github/workflows/nightly.yml

      - name: Run Archetype for EE 10 Web Profile, SE 17, WildFly
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=web -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
          rm -rf app/wildfly

      - name: Run Archetype for EE 8, SE 17, WildFly
        run: |
+


Why was this added?

m-reza-rahman · 2024-07-02T21:17:41Z

.github/workflows/nightly.yml

      - name: Set up Java SE 11
        uses: actions/setup-java@v3
        with:
          distribution: "temurin"
          java-version: 11

+


Where are the SE 8 cases for GlassFish?

m-reza-rahman

My guess is that this PR has some improper merge conflict resolution issues. Please re-inspect and fix.

m-reza-rahman · 2024-07-07T21:49:48Z

.github/workflows/nightly.yml

@@ -9,23 +9,23 @@ jobs:
  build-archetype:
    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:49:56Z

.github/workflows/nightly.yml

        with:
          distribution: "temurin"
          java-version: 8

      - name: Cache Maven packages
-        uses: actions/cache@v3
+        uses: actions/cache@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:50:08Z

.github/workflows/nightly.yml

          rm -rf app/wildfly

      - name: Set up Java SE 11
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:50:22Z

.github/workflows/nightly.yml

          rm -rf app/wildfly

      - name: Set up Java SE 17
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:50:41Z

.github/workflows/nightly.yml

  build-ui:
    runs-on: ubuntu-20.04
    steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:50:47Z

.github/workflows/nightly.yml

      - name: Setup Java
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:50:55Z

.github/workflows/nightly.yml

        with:
          distribution: "temurin"
          java-version: 11

      - name: Cache Maven packages
-        uses: actions/cache@v3
+        uses: actions/cache@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:51:32Z

.github/workflows/nightly.yml

        with:
          path: ~/.m2
          key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
          restore-keys: ${{ runner.os }}-m2

      - name: Build Archetype
        run: mvn clean install --file archetype/pom.xml
-      
+


Why is this white space change needed?

m-reza-rahman · 2024-07-07T21:51:41Z

.github/workflows/nightly.yml

@@ -125,7 +125,7 @@ jobs:
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=9.1 -Dprofile=web -DjavaVersion=8 -Druntime="open-liberty" -Ddocker=yes -DoutputDirectory="app/open-liberty" -Dgoals="clean package"
          rm -rf app/open-liberty
-      
+


Why is this white space change needed?

m-reza-rahman · 2024-07-07T21:51:51Z

.github/workflows/nightly.yml

@@ -291,7 +335,7 @@ jobs:
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=core -DjavaVersion=11 -Druntime="open-liberty" -Ddocker=yes -DoutputDirectory="app/open-liberty" -Dgoals="clean package"
          rm -rf app/open-liberty
-      
+


Why is this white space change needed?

m-reza-rahman · 2024-07-07T21:52:06Z

.github/workflows/nightly.yml

@@ -497,7 +586,7 @@ jobs:
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=core -DjavaVersion=17 -Druntime="open-liberty" -Ddocker=yes -DoutputDirectory="app/open-liberty" -Dgoals="clean package"
          rm -rf app/open-liberty
-  
+


Why is this white space change needed?

m-reza-rahman · 2024-07-07T21:52:17Z

.github/workflows/nightly.yml

Why is this white space change needed?

m-reza-rahman · 2024-07-07T21:52:56Z

.github/workflows/nightly.yml

@@ -139,6 +139,8 @@ jobs:
      - name: Run Archetype for EE 8, SE 8, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=full -DjavaVersion=8 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:53:15Z

.github/workflows/nightly.yml

      - name: Set up Java SE 8
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4


Please pull the latest from master. This diff should disappear.

m-reza-rahman · 2024-07-07T21:53:32Z

.github/workflows/nightly.yml

@@ -149,10 +151,12 @@ jobs:
      - name: Run Archetype for EE 8 Web Profile, SE 8, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=web -DjavaVersion=8 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:53:43Z

.github/workflows/nightly.yml

@@ -310,6 +354,8 @@ jobs:
      - name: Run Archetype for EE 8, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=full -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:53:50Z

.github/workflows/nightly.yml

@@ -320,6 +366,8 @@ jobs:
      - name: Run Archetype for EE 8 Web Profile, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=web -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:53:58Z

.github/workflows/nightly.yml

@@ -330,6 +378,8 @@ jobs:
      - name: Run Archetype for EE 10, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=full -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:54:05Z

.github/workflows/nightly.yml

@@ -340,6 +390,8 @@ jobs:
      - name: Run Archetype for EE 10 Web Profile, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=web -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:54:13Z

.github/workflows/nightly.yml

@@ -350,10 +402,12 @@ jobs:
      - name: Run Archetype for EE 10 Core Profile, SE 11, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=core -DjavaVersion=11 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:54:27Z

.github/workflows/nightly.yml

@@ -516,6 +605,8 @@ jobs:
      - name: Run Archetype for EE 8, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=full -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:54:34Z

.github/workflows/nightly.yml

@@ -526,6 +617,8 @@ jobs:
      - name: Run Archetype for EE 8 Web Profile, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=web -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:54:41Z

.github/workflows/nightly.yml

@@ -536,6 +629,8 @@ jobs:
      - name: Run Archetype for EE 10, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=full -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:54:48Z

.github/workflows/nightly.yml

@@ -546,6 +641,8 @@ jobs:
      - name: Run Archetype for EE 10 Web Profile, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=web -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman · 2024-07-07T21:54:56Z

.github/workflows/nightly.yml

@@ -556,25 +653,26 @@ jobs:
      - name: Run Archetype for EE 10 Core Profile, SE 17, WildFly, with Docker
        run: |
          mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=10 -Dprofile=core -DjavaVersion=17 -Druntime=wildfly -Ddocker=yes -DoutputDirectory=app/wildfly -Dgoals="clean package"
+          docker build -t test-image app/wildfly/jakartaee-hello-world


Please remove this. This is not related to GlassFish.

m-reza-rahman

Please address specific in-place feedback. Then I can review hopefully one last time before merge.

adan-jawad · 2024-07-13T14:37:55Z

Hello Reza, I am going to create a new pull request and I'm closing this one

adan-jawad added 2 commits June 24, 2024 20:12

Update 1 line 29-32 nightly.yml

8b013db

Positive cases Update nightly.yml

143e2fe

m-reza-rahman requested changes Jun 24, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft June 24, 2024 18:11

m-reza-rahman changed the title ~~Add all positive cases for Glassfish runtime~~ Add all positive cases for GlassFish runtime Jun 26, 2024

Archetype Positive Cases Glass Fish Update 2 nightly.yml

ebdc93f

adan-jawad marked this pull request as ready for review June 27, 2024 13:24

m-reza-rahman requested changes Jun 27, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft June 27, 2024 23:46

adan-jawad added 2 commits July 2, 2024 17:49

Positive Cases Ordering and Docker Description Update nightly.yml

c66197d

Removing cases with docker for Glassfish Update nightly.yml

3d0e0c3

adan-jawad marked this pull request as ready for review July 2, 2024 15:00

m-reza-rahman marked this pull request as draft July 2, 2024 15:18

Merge branch 'master' into master

ae8acb3

adan-jawad marked this pull request as ready for review July 2, 2024 15:31

m-reza-rahman reviewed Jul 2, 2024

View reviewed changes

m-reza-rahman requested changes Jul 2, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft July 2, 2024 21:22

adan-jawad marked this pull request as ready for review July 6, 2024 14:21

m-reza-rahman reviewed Jul 7, 2024

View reviewed changes

.github/workflows/nightly.yml

run: mvn clean package --file ui/pom.xml

Copy link

Contributor

m-reza-rahman Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this white space change needed?

m-reza-rahman reviewed Jul 7, 2024

View reviewed changes

m-reza-rahman requested changes Jul 7, 2024

View reviewed changes

m-reza-rahman marked this pull request as draft July 7, 2024 21:57

adan-jawad closed this Jul 13, 2024

		@@ -133,6 +144,10 @@ jobs:

		- name: Run Archetype for EE 8, SE 8, WildFly
		run: \|

Add all positive cases for GlassFish runtime #304

Add all positive cases for GlassFish runtime #304

Conversation

adan-jawad commented Jun 24, 2024

eclipse-starter-bot commented Jun 24, 2024

m-reza-rahman left a comment

Choose a reason for hiding this comment

adan-jawad commented Jun 27, 2024

m-reza-rahman left a comment

Choose a reason for hiding this comment

m-reza-rahman commented Jul 1, 2024

adan-jawad commented Jul 2, 2024

m-reza-rahman commented Jul 2, 2024

m-reza-rahman commented Jul 2, 2024

m-reza-rahman commented Jul 2, 2024

adan-jawad commented Jul 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-reza-rahman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-reza-rahman left a comment

Choose a reason for hiding this comment

adan-jawad commented Jul 13, 2024