Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring that LICENSE/NOTICE shows up in META-INF #283

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Ensuring that LICENSE/NOTICE shows up in META-INF #283

merged 2 commits into from
Nov 9, 2018

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Nov 8, 2018

This PR makes the LICENSE.md and NOTICE.md files show up in the META-INF directory of the two artifacts we produce.

markt-asf
markt-asf previously approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@markt-asf markt-asf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

markt-asf
markt-asf approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@markt-asf markt-asf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@markt-asf markt-asf merged commit 7501623 into jakartaee:master Nov 9, 2018
@joakime joakime mentioned this pull request Nov 9, 2018
Merged
@joakime joakime deleted the license-notice-in-meta-inf branch August 1, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markt-asf markt-asf markt-asf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joakime @markt-asf