Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check on possible null pointer dereference #621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rng70-or
Copy link

@rng70-or rng70-or commented Oct 9, 2023

Motivation

In file: DeserializationModelCreator.java, class: DeserializationModelCreator, there is a method createObjectDeserializer that there is a potential Null pointer dereference. This may throw an unexpected null pointer exception which, if unhandled, may crash the program. A developer should introduce null checks in the appropriate path or initialize the object explicitly.

Path of Possible Null Pointer Dereference

In file DeserializationModelCreator.java the following line of code (line 226)

CreatorModel creatorModel = creator.findByName(s);

invokes a method call of JsonbCreator class findByName

public CreatorModel findByName(String paramName) {
        for (CreatorModel param : params) {
            if (param.getName().equals(paramName)) {
                return param;
            }
        }
        return null;
    }

which can return null which was not properly checked before referencing CreatorModel from DeserializationModelCreator.java (line 227)

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

@rng70-or rng70-or changed the title fix: check on possible null pointer deference fix: check on possible null pointer dereference Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant