559102: Remove PDETargetPlatformUtils

Change-Id: I185247b9182e9ca6a6a27040a65d71d3321d7f62
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=559102
Signed-off-by: Lorenzo Bettini <lorenzo.bettini@gmail.com>

devtools/org.eclipse.emf.parsley.oomph/EMFParsley.setup

@@ -440,10 +440,7 @@
         </predicate>
       </sourceLocator>
       <sourceLocator
-          rootFolder="${git.clone.location}/tests">
-        <excludedPath>org.eclipse.emf.parsley.tests.pde.utils.kepler</excludedPath>
-        <excludedPath>org.eclipse.emf.parsley.tests.pde.utils.indigo</excludedPath>
-      </sourceLocator>
+          rootFolder="${git.clone.location}/tests"/>
     </setupTask>
     <setupTask
         xsi:type="setup.targlets:TargletTask">

dsl/org.eclipse.emf.parsley.dsl.ui.tests/META-INF/MANIFEST.MF

@@ -12,7 +12,6 @@ Require-Bundle: org.eclipse.emf.parsley.dsl.ui,
  org.eclipse.jdt.core,
  org.eclipse.xtext.common.types.ui,
  org.eclipse.emf.parsley.dsl.additional.builder,
- org.eclipse.emf.parsley.tests.pde.utils,
  org.eclipse.emf.parsley.views,
  org.eclipse.xtext.testing,
  org.eclipse.xtext.xbase.testing,

dsl/org.eclipse.emf.parsley.dsl.ui.tests/src/org/eclipse/emf/parsley/dsl/ui/tests/EmfParsleyDslContentAssistTest.xtend

@@ -16,13 +16,12 @@ import org.eclipse.emf.parsley.EmfParsleyGuiceModule
 import org.eclipse.emf.parsley.EmfParsleyJavaGuiceModule
 import org.eclipse.emf.parsley.dsl.tests.util.ui.PluginProjectHelper
 import org.eclipse.emf.parsley.dsl.ui.internal.DslActivator
-import org.eclipse.emf.parsley.tests.pde.utils.PDETargetPlatformUtils
 import org.eclipse.emf.parsley.views.EmfParsleyViewsActivator
 import org.eclipse.jdt.core.IJavaProject
 import org.eclipse.xtext.testing.InjectWith
 import org.eclipse.xtext.testing.XtextRunner
-import org.eclipse.xtext.ui.testing.ContentAssistProcessorTestBuilder
 import org.eclipse.xtext.ui.testing.AbstractContentAssistTest
+import org.eclipse.xtext.ui.testing.ContentAssistProcessorTestBuilder
 import org.junit.AfterClass
 import org.junit.BeforeClass
 import org.junit.Test
@@ -43,8 +42,6 @@ class EmfParsleyDslContentAssistTest extends AbstractContentAssistTest {
 
 	@BeforeClass
 	def static void setUp() {
-		PDETargetPlatformUtils.setTargetPlatform();
-
 		val injector = DslActivator.getInstance().getInjector
 			(DslActivator.ORG_ECLIPSE_EMF_PARSLEY_DSL_EMFPARSLEYDSL);
 

dsl/org.eclipse.emf.parsley.dsl.ui.tests/src/org/eclipse/emf/parsley/dsl/ui/tests/EmfParsleyDslWorkbenchTest.xtend

@@ -16,15 +16,13 @@ import org.eclipse.core.resources.IProject
 import org.eclipse.emf.parsley.dsl.generator.EmfParsleyDslOutputConfigurationProvider
 import org.eclipse.emf.parsley.dsl.tests.util.ui.PluginProjectHelper
 import org.eclipse.emf.parsley.dsl.tests.util.ui.TestableEmfParsleyDslNewProjectWizard
-import org.eclipse.emf.parsley.tests.pde.utils.PDETargetPlatformUtils
 import org.eclipse.jface.viewers.StructuredSelection
 import org.eclipse.jface.wizard.Wizard
 import org.eclipse.jface.wizard.WizardDialog
 import org.eclipse.ui.PlatformUI
-import org.eclipse.xtext.ui.testing.AbstractWorkbenchTest
 import org.eclipse.xtext.testing.InjectWith
 import org.eclipse.xtext.testing.XtextRunner
-import org.junit.BeforeClass
+import org.eclipse.xtext.ui.testing.AbstractWorkbenchTest
 import org.junit.Test
 import org.junit.runner.RunWith
 
@@ -80,11 +78,6 @@ class EmfParsleyDslWorkbenchTest extends AbstractWorkbenchTest {
 //		projectHelper.clearJdtIndex
 //	}
 
-	@BeforeClass
-	def static void beforeClass() {
-		PDETargetPlatformUtils.setTargetPlatform();
-	}
-
 	@Test def void testEmfParsleyDslNewProjectWizard() {
 		createProjectWithNewProjectWizard
 		projectHelper.assertNoErrors

releng/org.eclipse.emf.parsley.parent/pom.xml

@@ -81,7 +81,11 @@
 		<os-jvm-flags />
 		<memoryArgs>-Xms256M -Xmx4G -XX:PermSize=256M -XX:MaxPermSize=256M -XX:+HeapDumpOnOutOfMemoryError</memoryArgs>
 		<uiTestsArgs>${memoryArgs} ${os-jvm-flags} -Dorg.eclipse.swt.browser.DefaultType=mozilla</uiTestsArgs>
+		<!-- 
+		The following is not needed anymore
 		<pdeTestsArgs>-DbuildingWithTycho=true</pdeTestsArgs>
+		-->
+		<pdeTestsArgs></pdeTestsArgs>
 		<skipDragAndDropTests>true</skipDragAndDropTests>
 		<swtbotTestsArgs>${uiTestsArgs} -DskipDragAndDropTests=${skipDragAndDropTests} -Dorg.eclipse.swtbot.search.timeout=20000 -Dorg.eclipse.swt.internal.gtk.cairoGraphics=false</swtbotTestsArgs>
 
@@ -264,7 +268,6 @@
 
 				<module>../../releng/org.eclipse.emf.parsley.repository</module>
 
-				<module>../../tests/org.eclipse.emf.parsley.tests.pde.utils.luna</module>
 				<module>../../examples/org.eclipse.emf.parsley.examples.eclipse4</module>
 				<module>../../examples/org.eclipse.emf.parsley.examples.eclipse4.parsleypart</module>
 				<module>../../examples/org.eclipse.emf.parsley.examples.eclipse4.product.feature</module>

tests/org.eclipse.emf.parsley.tests.swtbot.feature/feature.xml

@@ -67,13 +67,6 @@
          install-size="0"
          version="0.0.0"/>
 
-   <plugin
-         id="org.eclipse.emf.parsley.tests.pde.utils"
-         download-size="0"
-         install-size="0"
-         version="0.0.0"
-         unpack="false"/>
-
    <plugin
          id="org.eclipse.emf.parsley.tests.views"
          download-size="0"

tests/org.eclipse.emf.parsley.tests.swtbot/META-INF/MANIFEST.MF

@@ -21,7 +21,6 @@ Require-Bundle: org.eclipse.swtbot.go;bundle-version="2.3.0",
  org.eclipse.emf.parsley.tests.models,
  org.objectweb.asm;bundle-version="5.0.1",
  org.eclipse.ui.editors;bundle-version="3.5.0",
- org.eclipse.emf.parsley.tests.pde.utils,
  org.eclipse.emf.parsley.examples.views,
  org.eclipse.emf.parsley.tests,
  org.eclipse.emf.parsley.examples.editors,

tests/org.eclipse.emf.parsley.tests.swtbot/pom.xml

@@ -106,7 +106,6 @@
 					<execution>
 						<id>PDEBasedTests</id>
 						<phase>integration-test</phase>
-						<!-- These tests required PDE and must pass -DbuildingWithTycho=true -->
 						<configuration>
 							<skip>${swtbot.tests.skip}</skip>
 							<useUIHarness>true</useUIHarness>

tests/org.eclipse.emf.parsley.tests.swtbot/src/org/eclipse/emf/parsley/tests/swtbot/EmfParsleySWTBotAbstractTests.java

@@ -11,7 +11,9 @@
 package org.eclipse.emf.parsley.tests.swtbot;
 
 import static org.eclipse.swtbot.swt.finder.waits.Conditions.shellCloses;
-import static org.eclipse.xtext.ui.testing.util.IResourcesSetupUtil.*;
+import static org.eclipse.xtext.ui.testing.util.IResourcesSetupUtil.cleanWorkspace;
+import static org.eclipse.xtext.ui.testing.util.IResourcesSetupUtil.createFile;
+import static org.eclipse.xtext.ui.testing.util.IResourcesSetupUtil.root;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
@@ -43,7 +45,6 @@
 import org.eclipse.emf.parsley.examples.library.Library;
 import org.eclipse.emf.parsley.examples.views.EmfParsleyExamplesViewsActivator;
 import org.eclipse.emf.parsley.junit4.ui.util.ImageTester;
-import org.eclipse.emf.parsley.tests.pde.utils.PDETargetPlatformUtils;
 import org.eclipse.emf.parsley.tests.swtbot.activator.EmfParsleySwtBotTestsActivator;
 import org.eclipse.emf.parsley.tests.swtbot.views.TestOnSelectionLibraryTreeViewWithResourceURI;
 import org.eclipse.emf.parsley.util.ActionBarsUtils;
@@ -364,8 +365,6 @@ public EmfParsleySWTBotAbstractTests() {
 
 	@BeforeClass
 	public static void beforeClass() throws Exception {
-		PDETargetPlatformUtils.setTargetPlatform();
-
 		// force loading of examples.views
 		EmfParsleyExamplesViewsActivator.getDefault();