useless overrides

methods in the interface don't need to be overridden as abstract in an abstract class
eclipse-emf-parsley · Nov 17, 2023 · f103d31 · f103d31
1 parent 09d0eda
commit f103d31
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 21 deletions.
diff --git a/plugins/org.eclipse.emf.parsley.common/.settings/.api_filters b/plugins/org.eclipse.emf.parsley.common/.settings/.api_filters
@@ -40,4 +40,36 @@
             </message_arguments>
         </filter>
     </resource>
+    <resource path="src/org/eclipse/emf/parsley/widgets/AbstractWidgetFactory.java" type="org.eclipse.emf.parsley.widgets.AbstractWidgetFactory">
+        <filter comment="useless to override as abstract methods of the interface" id="338792546">
+            <message_arguments>
+                <message_argument value="org.eclipse.emf.parsley.widgets.AbstractWidgetFactory"/>
+                <message_argument value="createButton(Composite, String, int)"/>
+            </message_arguments>
+        </filter>
+        <filter comment="useless to override as abstract methods of the interface" id="338792546">
+            <message_arguments>
+                <message_argument value="org.eclipse.emf.parsley.widgets.AbstractWidgetFactory"/>
+                <message_argument value="createComboViewer(Composite, int)"/>
+            </message_arguments>
+        </filter>
+        <filter comment="useless to override as abstract methods of the interface" id="338792546">
+            <message_arguments>
+                <message_argument value="org.eclipse.emf.parsley.widgets.AbstractWidgetFactory"/>
+                <message_argument value="createDateTime(Composite, int)"/>
+            </message_arguments>
+        </filter>
+        <filter comment="useless to override as abstract methods of the interface" id="338792546">
+            <message_arguments>
+                <message_argument value="org.eclipse.emf.parsley.widgets.AbstractWidgetFactory"/>
+                <message_argument value="createLabel(Composite, String)"/>
+            </message_arguments>
+        </filter>
+        <filter comment="useless to override as abstract methods of the interface" id="338792546">
+            <message_arguments>
+                <message_argument value="org.eclipse.emf.parsley.widgets.AbstractWidgetFactory"/>
+                <message_argument value="createText(Composite, String, int)"/>
+            </message_arguments>
+        </filter>
+    </resource>
 </component>
diff --git a/...org.eclipse.emf.parsley.common/src/org/eclipse/emf/parsley/EmfParsleyJavaGuiceModule.java b/...org.eclipse.emf.parsley.common/src/org/eclipse/emf/parsley/EmfParsleyJavaGuiceModule.java
@@ -78,7 +78,6 @@
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.events.MouseListener;
 
-import com.google.inject.Binder;
 import com.google.inject.Provider;
 
 /**
@@ -91,11 +90,6 @@
  */
 public class EmfParsleyJavaGuiceModule extends AbstractGenericModule {
 
-	@Override
-	public void configure(Binder binder) {
-		super.configure(binder);
-	}
-
 	/**
 	 * The String constant for Content Assist Shortcut
 	 */

diff --git a/...eclipse.emf.parsley.common/src/org/eclipse/emf/parsley/widgets/AbstractWidgetFactory.java b/...eclipse.emf.parsley.common/src/org/eclipse/emf/parsley/widgets/AbstractWidgetFactory.java
@@ -40,17 +40,11 @@ public Label createLabel(String text) {
 		return createLabel(parent, text);
 	}
 
-	@Override
-	public abstract Label createLabel(Composite parent, String text);
-
 	@Override
 	public Button createButton(String text, int... styles) {
 		return createButton(parent, text, aggregateStyles(styles));
 	}
 
-	@Override
-	public abstract Button createButton(Composite parent, String text, int style);
-
 	@Override
 	public Text createText(String text) {
 		return createText(parent, text);
@@ -71,17 +65,11 @@ public Text createText(Composite parent, int... styles) {
 		return createText(parent, "", aggregateStyles(styles));
 	}
 
-	@Override
-	public abstract Text createText(Composite parent, String text, int style);
-
 	@Override
 	public ComboViewer createComboViewer(int... styles) {
 		return createComboViewer(parent, aggregateStyles(styles));
 	}
 
-	@Override
-	public abstract ComboViewer createComboViewer(Composite parent, int style);
-
 	@Override
 	public DateTime createDateTime() {
 		return createDateTime(parent, SWT.DROP_DOWN);
@@ -97,9 +85,6 @@ public DateTime createDateTime(Composite parent) {
 		return createDateTime(parent, SWT.DATE | SWT.DROP_DOWN);
 	}
 
-	@Override
-	public abstract DateTime createDateTime(Composite parent, int style);
-
 	protected int aggregateStyles(int... styles) {
 		int result = 0;
 		for (int s : styles) {