179: Convert all Modelserver-Node APIs to use URI instead of String #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert all public Modelserver-Node APIs to URI. This especially includes Providers and Services refs eclipse-emfcloud/emfcloud#179 Contributed on behalf of STMicroelectronics Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
ndoschek
requested changes
Nov 2, 2022
There was a problem hiding this comment.
Thank you @CamilleLetavernier, changes look good to me overall.
I just noticed some minor inconsistencies in the way of importing and a few missed explicit imports.
Would be great if you could have another look, thank you!
- Use consistent import statements Contributed on behalf of STMicroelectronics Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
ndoschek
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs eclipse-emfcloud/emfcloud#179
Contributed on behalf of STMicroelectronics
Signed-off-by: Camille Letavernier cletavernier@eclipsesource.com