-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Java-NIO to write EclipsePreferences #8
Use Java-NIO to write EclipsePreferences #8
Conversation
@HannesWell : where's "Check Code Freeze Period" check? Shouldn't that now be executed? |
This commit may need to be rebased for workflow updates to be available. |
They should indeed be executed. For PDE this already works (see my latest PR there). I suspect this is because GH Actions are not yet activated for all Equinox projects at all. But I have already asked the Webmaster-team to enabled them: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1148 So until the next freeze-period they should be available. |
508b30a
to
2a4b6e9
Compare
But what makes me wonder is the compilation failure in the build:
The marked methods where all introduced in Java-10/11 so they should be available. The BREE and the jdt-preferences of the project are all at Java-11 |
Can you reproduce this failure with a local build? |
Looks to me that build.properties still enforces Java 8, I push a separate PR for this. |
2a4b6e9
to
4b4fb02
Compare
Nice. Will it also be faster? |
Probably not significantly faster, because the general IO-operations are still performed. :/ |
@HannesWell Android offers a async way to persist perferences. Maybe we should add this also to Equinox? |
I'm a bit doubtful that saving preferences needs optimization... |
@jukzi did you every see deplay due to preference saves? |
no. |
I agree with the others that it is likely not worth the effort. In general avoiding IO-operations is usually much more beneficial than just parallelizing it. Therefore I would spend my time and code-complexity there. |
This PR aims to simplify the write of Eclipse-Preferences by using Java-NIO, which makes SafeFileOutputStream obsolete.