Trouble with UNC-Uris: Should I add URI-factories to URIUtil?

[cmorty]

I currently adding WSL support to CDT. A problem I'm facing is the $ in WSL's UNC-Path ( \\WSL$\...). The URIUtil.java has a private function to handle UNC-Paths:
https://github.com/eclipse-equinox/equinox.bundles/blob/16f8cde25e358cee86ac73634cf06e362b4d2c16/bundles/org.eclipse.equinox.common/src/org/eclipse/core/runtime/URIUtil.java#L105

I have an open PR for append() ( eclipse-equinox/equinox.bundles#47 ). However there are multiple places in CDT that create an URI with the "long" URI-Ctor, passing the UNC-Path as as path-parameter. Some of the places already have special UNC-handling and some don't. As CDT certainly isn't the only project with this issue, I think it would be really helpful to provide a UNC-safe URI-factory (Of course fixing java.net.URI would much better, but from what I've read, that is not going to happen). So my idea is to provide UNC-safe factories for the following Ctors:

• URI(String scheme, String userInfo, String host, int port, String path, String query, String fragment)
• URI(String scheme, String host, String path, String fragment)
• URI(String scheme, String authority, String path, String query, String fragment)

This would, of course, make my other PR obsolete because I'd just call the UNC-safe URI-factory instead of fixing the path in append().

Any thoughts?

CC: @jonahgraham