Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven verification workflow #1

Merged

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jun 15, 2022

No description provided.

@laeubi laeubi force-pushed the setup_github_verification_flow branch 3 times, most recently from ab503e8 to bd557f0 Compare June 15, 2022 15:48
@akurtakov
Copy link
Member

Please don't merge things until both repos are merged and switch is done to prevent any delays.

@laeubi laeubi force-pushed the setup_github_verification_flow branch from bd557f0 to 662c54c Compare June 15, 2022 16:15
@laeubi
Copy link
Member Author

laeubi commented Jun 15, 2022

Please don't merge things until both repos are merged and switch is done to prevent any delays.

This should be independent of that or do you think there are any problems?

@laeubi
Copy link
Member Author

laeubi commented Jun 15, 2022

@mickaelistria the build complains:

Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.equinox.compendium.sdk: Only qualifier changed for (org.eclipse.equinox.compendium.sdk.feature.jar/3.22.300.v20220615-0641). Expected to have bigger x.y.z than what is available in baseline (3.22.300.v20220503-1634)

As this does not touch any code: could it be related to the recent move of the repository?

@mickaelistria
Copy link
Contributor

could it be related to the recent move of the repository?

Yes, most likely the merge commit has affected that module a way or another so the versions should be bumped. If you don't want to bump the version, you'll need to see what has changed in history compared to 3.22.300.v20220503-1634 and maybe exclude this file from the "watched" ones that are used to derive the qualifier. But just bumping is much easier...

@laeubi
Copy link
Member Author

laeubi commented Jun 15, 2022

Okay as @akurtakov has already mentioned its maybe good to wait until the merge of the runtime is done (i'll try to find some time if no one else step up here), so we catch all bumps at once, I just wanted to make sure that its not a useless bump.

@vogella
Copy link
Contributor

vogella commented Jun 15, 2022 via email

@akurtakov
Copy link
Member

I think this can be finished/merged now.

@laeubi laeubi force-pushed the setup_github_verification_flow branch 4 times, most recently from 1142f2d to 0401528 Compare June 16, 2022 09:26
@vogella
Copy link
Contributor

vogella commented Jun 16, 2022

Once the Github action works correctly, we may want to discuss to stop using Jenkins for build verification. GH actions seems to be faster and easier to configure.

@laeubi
Copy link
Member Author

laeubi commented Jun 16, 2022

I found it useful in the past two have both but of course this might change over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants