Port o.e.equinox.http.jetty to Jetty 12 #317
Conversation
Test Results 24 files ±0 24 suites ±0 12m 25s ⏱️ +23s Results for commit 9f72d29. ± Comparison against base commit 4c41c80. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
|
@akurtakov I just wanted to note that jetty itself brings an OSGi-HTTP-Service implementation, since that service is deprecated by the spec, we might want to drop the equinox impl all together and use the jetty one where needed (I think its only the help?) |
Would you please give links to Jetty's OSGi-HTTP-Service implementation and to the deprecation in the spec for references here? |
|
OSGi R7 is the last specification containing HttpService: R8.1 has now removed it from the spec: Sadly as far as I know there are no real deprecation notices (but @bjhargrave , @tjwatson or @timothyjward might have a reference somewhere) Also the this (failed) attempt to upgrade The jetty-osgi bundles live here: Apache Felix also offers https://cwiki.apache.org/confluence/display/FELIX/Apache+Felix+HTTP+Service |
akurtakov
force-pushed
the
master
branch
3 times, most recently
from
249e964
to
f54d4bf
Compare
Because it was never deprecated. The chapter just was not included in the 8.1 specification. There are no plans to enhance it or provide the equivalent for Jakarta Servlet. But Java Servlet users are free to keep using an implementation of the Http Service. The problem Equinox has is that we have various services that are built upon the old Http Service that:
The main one is the But I don't want to conflate updating to Jakarta with the work here that Alex has started, because it seems unrelated since Jetty 12 decouples the EE version (javax vs jakarta) so seems updating to Jetty 12 does not force Jakarta on us. |
Port is straightforward except for logging as EquinoxStdErrLog had to be removed as this org.eclipse.jetty.util.log api is totally gone and has been deprecated since Jetty 10.x. According to https://eclipse.dev/jetty/documentation/jetty-12/operations-guide/index.html#og-server-logging there is no longer programatic way to configure logging. Disabled cross context dispatching test as it's not supported in Java 12 as per jetty/jetty.project#10617 .
|
Cross context dispatch is not working because of jetty/jetty.project#10617 but as this seems to not be priority for Jetty we should just move on. |
Port is straightforward except for logging as EquinoxStdErrLog had to be removed as this org.eclipse.jetty.util.log api is totally gone and has been deprecated since Jetty 10.x.
According to
https://eclipse.dev/jetty/documentation/jetty-12/operations-guide/index.html#og-server-logging there is no longer programatic way to configure logging.