Switch Jetty to requires in feature.xml #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sravanlakkimsetti Any reason no to go that path? |
That should avoid having to touch the feature everytime Jetty version is changed. Minor version bumped for easily tracking this change.
|
Might this result in these being missing from the repository? I'd test that to be sure that's not a problem like perhaps this one is problem: |
|
Pushing this one and starting I-build - hopefully everything works that way. |
|
Jetty bundles are in the repo https://download.eclipse.org/eclipse/updates/4.25-I-builds/I20220629-0320/plugins/ so looks fine so far. |
|
@akurtakov Thanks for trying this out! This should greatly simplify referencing non-reactor dependencies in features now! |
This was referenced Jul 9, 2022
Merged
laeubi
pushed a commit
to laeubi/equinox
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should avoid having to touch the feature everytime Jetty version is
changed.