Synchronize on the manager in RepositoryHelper#createMemoryComposite #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the RepositoryHelper#createMemoryComposite uses the current time millis to generate a "unique" URI, but this has several issues: Two threads can enter the method at the same time and then see that this "unique" id is currently not taken and then get the same id. It can even happen that both try to create them at the same time, what then will result in a provision exception what will return null and results in no composite created at all. This do the following to mitigate this: - uses a UUID instead of timestamp where collisions are already unlikely - synchronize on the manager for the time of test/create the repository
laeubi
added a commit
to laeubi/tycho
that referenced
this pull request
Dec 16, 2023
laeubi
added a commit
to eclipse-tycho/tycho
that referenced
this pull request
Dec 17, 2023
github-actions bot
pushed a commit
to eclipse-tycho/tycho
that referenced
this pull request
Dec 17, 2023
(cherry picked from commit e9676af)
laeubi
added a commit
to eclipse-tycho/tycho
that referenced
this pull request
Dec 17, 2023
(cherry picked from commit e9676af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the RepositoryHelper#createMemoryComposite uses the current time millis to generate a "unique" URI, but this has several issues:
Two threads can enter the method at the same time and then see that this "unique" id is currently not taken and then get the same id. It can even happen that both try to create them at the same time, what then will result in a provision exception what will return null and results in no composite created at all.
This do the following to mitigate this: