Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zenoh and yaks dependencies in BUILD.md #172

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

gabrielepmattia
Copy link
Contributor

@gabrielepmattia gabrielepmattia commented Jan 27, 2020

See issue #170

@gabrik
Copy link
Contributor

gabrik commented Jan 27, 2020

Thanks @gabrielepmattia for your contribution.
However, in order to accept this, you need to sign your comment.
You can do this by running git commit --amend -s
And you need to sing the Eclipse Contribution Agreement, see https://github.com/eclipse-fog05/fog05/blob/master/CONTRIBUTING.md#eclipse-contributor-agreement

Once you have done that we can review the PR and accept the contribution.
You can also update the CONTRIBUTORS.rst file with your name if you wish.

@gabrik gabrik self-assigned this Jan 27, 2020
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
@gabrielepmattia
Copy link
Contributor Author

Perfect, I think I'm done

@gabrik
Copy link
Contributor

gabrik commented Jan 30, 2020

Thanks for your contribution!
I'll merge that once we got the approval for the dependencies from Eclipse (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=21517)

@gabrik gabrik merged commit 8a4992c into eclipse-fog05:master Jan 31, 2020
gabrik pushed a commit that referenced this pull request Nov 26, 2020
* Update zenoh and yaks dependencies in BUILD.md

Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>

* Added me in contributors list

Signed-off-by: Gabriele Proietti Mattia <pm.gabriele@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants