GH-628 Use generic context menu mouse event instead of right click event #183
Conversation
- Update to latest sprotty version - Update `SelectionServiceAwareContextMenuMouseListener` to use the `contextmenu` mouse event instead of the `right-click` event. Fixes eclipse-glsp/glsp#628
Sprotty only updates the selection on mouse button 0 (left-click). However, this is actually inconsistent with other software's behavior as they usually update the selection on any mouse click. If we do the same GLSP editors behavior much more consistently and we also can get rid of the special case of context menu invocation.
There was a problem hiding this comment.
Looks great, thanks! Now also the context-menu button on the keyboard works! 👍
However, I found an issue:
If you select an element first (left-click) and then right-click on another element, the previous element is not unselected. So if you now select "Delete" from the context menu, the previously selected element is also deleted.
Imho this is a bit unexpected.
I suggest that we now modify the select mouse tool to also update the selection on any other mouse click (not just mouse button 0 === left-click). This is actually more consistent with other software, if you e.g. try a right-click or even wheel click in VS Code you'll see that it updates the selection too). This makes also the special handling regarding the selection in the context menu listener obsolete.
I'll append a commit for you to review.
|
Thanks. Looks good to me! |
SelectionServiceAwareContextMenuMouseListenerto use thecontextmenumouse event instead of theright-clickevent.Fixes eclipse-glsp/glsp#628