Add SVGMetadata API #239
Merged
Add SVGMetadata API #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haydar-metin I'll try to have a look a bit later that week. Could you please resolve the merge conflicts? Thank you! |
martin-fleck-at
requested changes
Apr 10, 2023
There was a problem hiding this comment.
Hi @haydar-metin, the change looks good to me technically. I'd even suggest to put the module in the general default modules as it just adds some metadata. However, I think we need to adapt the copyright header - at least the year - and maybe the copyright owner as well.
martin-fleck-at
requested changes
Apr 17, 2023
I will ask @borkdominik for further information |
|
@haydar-metin If you confirm the copyright, I think we can merge this change. |
martin-fleck-at
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of my diploma research conducted at the Model Engineering lab of TU Wien in the Business Informatics Group.
It adds the necessary SVGMetadataAPI for
glsp-playwright.eclipse-glsp/glsp-playwright#1
Contact: @martin-fleck-at, @planger, @ndoschek