-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLSP-960: Follow-up #282
Merged
Merged
GLSP-960: Follow-up #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide `DiagamLoaderOptions` to support dynamic configuration of the loading behavior Follow-up for eclipse-glsp/glsp/issues/960
tortmayr
force-pushed
the
issues/tortmayr/960
branch
from
September 4, 2023 09:38
b09681e
to
6f8ba43
Compare
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Sep 4, 2023
Adapt to latest client changes Part of eclipse-glsp/glsp/issues/960 Requires eclipse-glsp/glsp-client#282
tortmayr
added a commit
to eclipse-glsp/glsp-eclipse-integration
that referenced
this pull request
Sep 4, 2023
Update client and server to consume latest changes for GLPS-960 Part of eclipse-glsp/glsp/issues/960 Requires eclipse-glsp/glsp-client#282
This was referenced Sep 4, 2023
tortmayr
added a commit
to eclipse-glsp/glsp-vscode-integration
that referenced
this pull request
Sep 4, 2023
- Use vscode-messenger protocol for webview-extension communication - Refactor webview communication code into `WebviewEndpoint` class - Introduce a `WebviewGLSPClient` that forwards RPC calls to the GLSP client running in the host extension - Refactor and update codebase to conform to changes from GLSP-960 Part of eclipse-glsp/glsp/issues/960 Requires eclipse-glsp/glsp-client#282
planger
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! 👍
tortmayr
added a commit
to eclipse-glsp/glsp-vscode-integration
that referenced
this pull request
Sep 4, 2023
- Use vscode-messenger protocol for webview-extension communication - Refactor webview communication code into `WebviewEndpoint` class - Introduce a `WebviewGLSPClient` that forwards RPC calls to the GLSP client running in the host extension - Refactor and update codebase to conform to changes from GLSP-960 Part of eclipse-glsp/glsp/issues/960 Requires eclipse-glsp/glsp-client#282
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Sep 4, 2023
Adapt to latest client changes Part of eclipse-glsp/glsp/issues/960 Requires eclipse-glsp/glsp-client#282
tortmayr
added a commit
to eclipse-glsp/glsp-eclipse-integration
that referenced
this pull request
Sep 4, 2023
* GLSP-960: Improve Diagram container configuration Update client and server to consume latest changes for GLPS-960 Part of eclipse-glsp/glsp/issues/960 Requires eclipse-glsp/glsp-client#282 * Update client
tortmayr
added a commit
to eclipse-glsp/glsp-vscode-integration
that referenced
this pull request
Sep 4, 2023
* GLSP-960: Improve Diagram container configuration - Use vscode-messenger protocol for webview-extension communication - Refactor webview communication code into `WebviewEndpoint` class - Introduce a `WebviewGLSPClient` that forwards RPC calls to the GLSP client running in the host extension - Refactor and update codebase to conform to changes from GLSP-960 Part of eclipse-glsp/glsp/issues/960 Requires eclipse-glsp/glsp-client#282
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Sep 4, 2023
Adapt to latest client changes Part of eclipse-glsp/glsp/issues/960 Requires eclipse-glsp/glsp-client#282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
DiagamLoaderOptions
to support dynamic configuration of the loading behaviorFollow-up for eclipse-glsp/glsp/issues/960