Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-960: Follow-up #282

Merged
merged 1 commit into from Sep 4, 2023
Merged

GLSP-960: Follow-up #282

merged 1 commit into from Sep 4, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Sep 4, 2023

Provide DiagamLoaderOptions to support dynamic configuration of the loading behavior

Follow-up for eclipse-glsp/glsp/issues/960

 Provide `DiagamLoaderOptions` to support dynamic configuration of the loading behavior

Follow-up for eclipse-glsp/glsp/issues/960
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this pull request Sep 4, 2023
Adapt to latest client changes
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this pull request Sep 4, 2023
Update client and server to consume latest changes for GLPS-960
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this pull request Sep 4, 2023
- Use vscode-messenger protocol for webview-extension communication
- Refactor webview communication code into `WebviewEndpoint` class
- Introduce a `WebviewGLSPClient` that forwards RPC calls to the GLSP client running in the host extension
- Refactor and update codebase to conform to changes from GLSP-960
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit d450dd9 into master Sep 4, 2023
6 checks passed
@tortmayr tortmayr deleted the issues/tortmayr/960 branch September 4, 2023 12:35
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this pull request Sep 4, 2023
- Use vscode-messenger protocol for webview-extension communication
- Refactor webview communication code into `WebviewEndpoint` class
- Introduce a `WebviewGLSPClient` that forwards RPC calls to the GLSP client running in the host extension
- Refactor and update codebase to conform to changes from GLSP-960
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this pull request Sep 4, 2023
Adapt to latest client changes
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this pull request Sep 4, 2023
* GLSP-960: Improve Diagram container configuration 

Update client and server to consume latest changes for GLPS-960
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282

* Update client
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this pull request Sep 4, 2023
* GLSP-960: Improve Diagram container configuration 

- Use vscode-messenger protocol for webview-extension communication
- Refactor webview communication code into `WebviewEndpoint` class
- Introduce a `WebviewGLSPClient` that forwards RPC calls to the GLSP client running in the host extension
- Refactor and update codebase to conform to changes from GLSP-960
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants