GLSP-865: Align client model namespace with server model #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fleck-at
requested changes
Oct 9, 2023
Also export all SModel elements (and releated) as aliased/augmented classes in the `GModel` namespace. This means we now can consistently use the GModel syntax on both server and client side. Move package-internal glsp-sprotty reexport into dedicated package. The package-internal reexport required overhead with `tsc-alias` which did not play well with the test setup and ide support (auto-import). Using a dedicated package also improved DevXP in glsp-client as auto-import now longer suggests imports from sprotty or sprotty-protocol. Sprotty and GLSP use different definitions of `Action`. While they are fully compatible this kind of breaks the IDE support for API that uses `Action`. e.g. Implementing an `IActionHandler` would have always auto-imported the wrong `Action` type (from sprotty-protocol). To bypass this issue we extend the sprotty core API classes in question and reexport them instead (see action-override.ts). Also: - reexport sprotty modules that are used in glsp as `FeatureModules`. - Refactor `Argumentable` interface to a model feature and rename to `ArgsAware` and ensure that the argsFeature gets added to each element per default - Augment all actions directly provided by sprotty-protocol to provide a typeguard via namespace - Move all reusable autocomplete compontens into base package - Remove "baseUrl" from tsconfig to avoid breaking "src" auto imports in vscode Part of eclipse-glsp/glsp/issues/865
martin-fleck-at
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also export all SModel elements (and releated) as aliased/augmented classes in the
GModelnamespace. This means we now can consistently use the GModel syntax on both server and client side.Move package-internal glsp-sprotty reexport into dedicated package. The package-internal reexport required overhead with
tsc-aliaswhich did not play well with the test setup and ide support (auto-import). Using a dedicated package also improved DevXP in glsp-client as auto-import now longer suggests imports from sprotty or sprotty-protocol.Sprotty and GLSP use different definitions of
Action. While they are fully compatible this kind of breaks the IDE support for API that usesAction. e.g. Implementing anIActionHandlerwould have always auto-imported the wrongActiontype (from sprotty-protocol). To bypass this issue we extend the sprotty core API classes in question and reexport them instead (see action-override.ts).Also:
FeatureModules.Argumentableinterface to a model feature and rename toArgsAwareand ensure that the argsFeature gets added to each element per defaultPart of eclipse-glsp/glsp/issues/865