#435 Fix Navigation from marker to affected element is no longer working #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
@ivy-lli Thank you for this fix! Works like a charm and is really clean and simple!
Correct me if I'm wrong but it looks like this PR also addresses eclipse-glsp/glsp#527 .
|
Hi @tortmayr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes eclipse-glsp/glsp#435
As already mentioned in the issue, this PR fixes the:
ModelInitializationConstraintso it waits for aSetModelActioninstead of aUpdateModelActionto be marked as initializededitor.setInjectormethod from the constructor to it's own method, to ensure that the IdeActionDispatcher is fully initialized by the DI before waitingCompletableFuture's are resumed