Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply KeyBindingFunction also for WebView2 #54

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

ivy-lmu
Copy link
Contributor

@ivy-lmu ivy-lmu commented Jun 7, 2022

@planger
Copy link
Member

planger commented Jun 9, 2022

@ivy-lmu Thank you very much for your contribution! 👏
Can you please sign the Eclipse Contributor Agreement for your email address? This is mandatory before we can integrate your fix. Thanks!

@ivy-lmu
Copy link
Contributor Author

ivy-lmu commented Jun 10, 2022

@planger I have already signed ECA. Unfortunately, my email on GitHub was set to private, so *@users.noreply.github.com is used for ECA validation. I just switched my email to public, but the validation seems to be stuck to the noreplay email. Can you somehow open a new validation?

@planger
Copy link
Member

planger commented Jun 10, 2022

@ivy-lmu Thanks! If I trigger revalidation it still uses the old one. Can you please force-push a commit with your email address? Maybe that re-triggers the validation with the correct address.

@planger
Copy link
Member

planger commented Jun 10, 2022

I think you also have to update the author in the commit and force-push it. Currently it is:

commit 80e56216357749077f22227b74255468d8a5ece5 (HEAD -> ivy-lmu-issues/678)
Author: Louis <93579455+ivy-lmu@users.noreply.github.com>
Date:   Tue Jun 7 16:13:52 2022 +0200

    Apply KeyBindingFunction also for WebView2. Fixes https://github.com/eclipse-glsp/glsp/issues/678

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, thank you very much for the contribution!

@martin-fleck-at martin-fleck-at merged commit 2722492 into eclipse-glsp:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Eclipse key bindings in WebView2
4 participants