General refactoring and cleanup #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure consistent usage of `ModelState` Previously the default implementations used and inconsistent mix of injecting `GModelState` (the custom model state for the direct Gmodel lib) and `ModelState` (the default class). This introduced and indirect dependency to the `GModelDiagramModule`. Since the `GModelState` actually did only contain generally reusable code it has been removed and merged with `ModelState`. All default implementations now consistently inject the `ModelState`. - Move all services (action & operations handlers etc.) that contain implementation specific code for the direct gmodel usecase (graphical model === source model) into a dedicated `gmodel-lib` subdirectory. - Extract a reusable `AbstractJsonModelStorage` base implementation from the `GModelStorage` that can be reused for any model storage that loads JSON models from files. - Introduce a generic abstract base implementation for `CreateNodeOperationHandlers`. - Ensure that the `OperationHandler` correctly sets the reason when dispatching a new `SetDirtyStateAction` - Fix issue in `ChangeBoundsOperationHandler`. Only set the `prefWidth, prefHeight` layout options if the changed object has a `layout` property. - Cleanup index imports s21 Fix change-bounds-operation-handler save model action s
tortmayr
added a commit
to eclipse-glsp/glsp-examples
that referenced
this pull request
Apr 25, 2022
Setup glsp server and client Consume latest glsp server and client Load and save to a json resource Supports creation and deletion, resizing, moving of nodes as well as label editing. Part of eclipse-glsp/glsp#622 Requires: eclipse-glsp/glsp-vscode-integration#26 Requires: eclipse-glsp/glsp-server-node#16 Contributed on behalf of STMicroelectronics.
planger
approved these changes
Apr 26, 2022
planger
pushed a commit
to eclipse-glsp/glsp-examples
that referenced
this pull request
Apr 28, 2022
Setup glsp server and client Consume latest glsp server and client Load and save to a json resource Supports creation and deletion, resizing, moving of nodes as well as label editing. Part of eclipse-glsp/glsp#622 Requires: eclipse-glsp/glsp-vscode-integration#26 Requires: eclipse-glsp/glsp-server-node#16 Co-authored-by: Philip Langer <planger@eclipsesource.com> Contributed on behalf of STMicroelectronics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure consistent usage of
ModelStatePreviously the default implementations used and inconsistent mix of injecting
GModelState(the custom model state for the direct Gmodel lib)and
ModelState(the default class). This introduced and indirect dependency to theGModelDiagramModule. Since theGModelStateactually did only contain generally reusable code it has been removed and merged withModelState. All default implementations now consistently inject theModelState.Move all services (action & operations handlers etc.) that contain implementation specific code for the direct gmodel usecase (graphical model === source model) into a dedicated
gmodel-libsubdirectory.Extract a reusable
AbstractJsonModelStoragebase implementation from theGModelStoragethat can be reused for any model storagethat loads JSON models from files.
Introduce a generic abstract base implementation for
CreateNodeOperationHandlers.Ensure that the
OperationHandlercorrectly sets the reason when dispatching a newSetDirtyStateActionFix issue in
ChangeBoundsOperationHandler. Only set theprefWidth, prefHeightlayout options if the changed object has alayoutproperty.Cleanup index imports
s21
Fix change-bounds-operation-handler
save model action
s