GH-631 Improve to service bindings in diagram module #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update behavior of `applyBindingsTarget` for binding `ServiceTargets`. Add an optional `autoBind` flag to `ServiceTarget` which is enabled by default. If the target service identifier is not bound yet and this flag is enabled we check whether the target service can be bound to itself in singleton scope. If so we do that, otherwise we throw an error. This covers the most common case for our `ServiceBindings`: Subclassing a default implementation and then bind the service identifier to this implementation. (e.g. bind(MyModelState).toSelf().inSingletonScope(); bind(ModelState).toService(MyModelState)) For more complex binding configurations its still possible to access the binding context directly (this.context) and apply the bindings this way. Closes eclipse-glsp/glsp#631 Also: Fix unused model state parameter in workflow builder methods.
tortmayr
added a commit
to eclipse-glsp/glsp-examples
that referenced
this pull request
May 4, 2022
Consume improvements of eclipse-glsp/glsp-server-node#19
tortmayr
added a commit
to eclipse-glsp/glsp-examples
that referenced
this pull request
May 4, 2022
Consume improvements of eclipse-glsp/glsp-server-node#19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update behavior of
applyBindingsTargetfor bindingServiceTargets.Add an optional
autoBindflag toServiceTargetwhich is enabled by default.If the target service identifier is not bound yet and this flag is enabled we check
whether the target service can be bound to itself in singleton scope.
If so we do that, otherwise we throw an error.
This covers the most common case for our
ServiceBindings: Subclassing a default implementation and then bind the service identifier to this implementation.(e.g. bind(MyModelState).toSelf().inSingletonScope();
bind(ModelState).toService(MyModelState))
For more complex binding configurations its still possible to access the binding context directly (this.context) and apply the bindings this way.
Closes eclipse-glsp/glsp#631
Also: Fix unused model state parameter in workflow builder methods.